Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Final Report #848

Merged
merged 6 commits into from Feb 23, 2024
Merged

Added Final Report #848

merged 6 commits into from Feb 23, 2024

Conversation

tvcastillod
Copy link
Contributor

Hello, here is the final report of GSoC.

image

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #848 (4d97123) into master (e0741be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files          44       44           
  Lines       10454    10454           
  Branches     1411     1411           
=======================================
  Hits         8833     8833           
  Misses       1252     1252           
  Partials      369      369           

Copy link
Contributor

@ganimtron-10 ganimtron-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tvcastillod,
The final report lgtm.
However, there is some scope of improvement like highlighting specific words, concepts or function and so on.

Copy link
Contributor

@JoaoDell JoaoDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvcastillod, I have just finished reviewing you final report and it was really cool to get a general overview of your GSoC work, I haven't understand it untill now and it is complex and very interdisciplinary, so congratulations for handling all of this throughout this summer! I have left some comments below where I think some phrases could be improved, but it all built fine.

Copy link
Contributor

@guaje guaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, just minor typos and improvements for clarity.

@skoudoro skoudoro merged commit eed7931 into fury-gl:master Feb 23, 2024
22 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants