Utils test and winding order algorithm #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @lidonohu! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 88.37% 88.45% +0.07%
==========================================
Files 17 17
Lines 4234 4262 +28
Branches 529 532 +3
==========================================
+ Hits 3742 3770 +28
Misses 354 354
Partials 138 138
|
skoudoro
reviewed
Mar 12, 2020
| def what_order(verts, tri): | ||
| """Determines the winding order of a given set of vertices and a triangle | ||
|
|
||
| Parameter |
|
|
||
| npt.assert_equal(test_tri[0], utils.change_order(test_tri[1])) | ||
|
|
||
| npt.assert_equal(test_tri[2], utils.change_order(test_tri[3])) |
|
|
||
| Returns | ||
| ------- | ||
| 0 or 1: int |
There was a problem hiding this comment.
order_type : bool instead
| def change_order(tri): | ||
| """ Changes the order of a given triangle | ||
|
|
||
| Parameter |
|
|
||
| Returns | ||
| ------- | ||
| np.array(newVert): ndarray |
There was a problem hiding this comment.
new_verts : array instead
|
|
||
|
|
||
| def check_order(vert, triarr): | ||
| """ |
| def check_order(vert, triarr): | ||
| """ | ||
|
|
||
| Parameter |
|
Thank you really much for this work @lidonohu! merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing previous PR, all changes made and redone.