Added cylinder primitive

[tushar5526]

Closes #318
Referred to this source for generating vertices and triangles.
Formatted the primitive.py according to PEP 8.

[pep8speaks]

Hello @tushar5526! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file fury/primitive.py:

Line 771:80: E501 line too long (87 > 79 characters)

• In the file fury/tests/test_primitive.py:

Line 111:80: E501 line too long (82 > 79 characters)

Comment last updated at 2020-10-08 11:11:02 UTC

[codecov]

Codecov Report

Merging #328 into master will increase coverage by 0.10%.
The diff coverage is 95.18%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   88.65%   88.75%   +0.10%     
==========================================
  Files          21       21              
  Lines        5075     5156      +81     
  Branches      656      672      +16     
==========================================
+ Hits         4499     4576      +77     
- Misses        406      408       +2     
- Partials      170      172       +2     

Impacted Files	Coverage Δ
fury/primitive.py	91.54% <95.18%> (+2.15%)	⬆️

[skoudoro]

Thank you @tushar5526 for this primitive!

we will look into it and give you more detailed comments. But for now, can you add some unit tests? You can look at https://github.com/fury-gl/fury/blob/master/fury/tests/test_primitive.py.

Thank you.

[tushar5526]

Thank you for reviewing. Will add the tests soon :)

[tushar5526]

@skoudoro, I am a little confused about how to implement the tests for this, I can assert the ndarray shape values, and do I have to check the e_mean, e_min, e_max by using hard-coded values?
PS: I have never written tests before so if there is anything I need to keep in mind, do tell me.
Thanks

[skoudoro]

Overall, it looks good. It will be good if you could change the default orientation of the cylinder (length along Y instead of Z).
See below:

I created a PR in your fork to add some tests https://github.com/tushar5526/fury/pull/2. it is just missing a test when it is capped. I let you add this one last one.

[tushar5526]

Cylinder's base is on XZ plane now and the axes on Y.
Reproduced the mesh in unity for testing.

[skoudoro]

This PR looks good to me and is ready to go.

I will wait for any additional comments until tomorrow and then merge it.

[skoudoro]

Thank you @tushar5526