Fixing UI warnings #332
Merged
Fixing UI warnings #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
approved these changes
Oct 24, 2020
There was a problem hiding this comment.
LGTM, thanks @Nibba2018! I do not know why Azure pipeline failed so I just restarted them. but your PR is ready to go
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 88.75% 88.75%
=======================================
Files 21 21
Lines 5157 5157
Branches 672 672
=======================================
Hits 4577 4577
Misses 408 408
Partials 172 172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #317
The following warning:
DeprecationWarning: Converting 'np.character' to a dtype is deprecated. The current result is 'np.dtype(np.str_)' which is not strictly correct. Note that 'np.character' is generally deprecated and 'S1' should be used.is generated when numpy arrays are converted to vtk arrays in
vtk.util.numpy_support.get_vtk_array_type. This method is mainly used by the methods infury.utilsandfury.actors. This warning is generated when arrays contain character values in them, but while test I was not able to find any character values present in the array when the tests are run.This warning is also the most recurring warning compared to the rest and also the only one in
fury.ui. I created a filepytest.inito ignore this particular warning and got the following results:892to14108to0I am not sure if there is a better way to fix these.