New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Summer of Code blog posts #476
Conversation
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 88.41% 88.53% +0.11%
==========================================
Files 31 31
Lines 6519 6575 +56
Branches 782 787 +5
==========================================
+ Hits 5764 5821 +57
Misses 535 535
+ Partials 220 219 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @devmessias,
The docs can not be generated. There are some issues in your blog post. Please can you generate the documentation locally, get a look and fix it. Thanks!
Can you also review this PR @SunTzunami and @antrikshmisri?
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more comments
Hi @devmessias! It's quite a detailed blog with nice explanations. A few typos need to be fixed and the links seem to be breaking probably due to incorrect rst syntax, please rectify that and it'll be good. |
176a7ae
to
64684a8
Compare
Thanks @skoudoro and @SunTzunami I need to rebase this
|
if you have issue with the examples/tutorials during the generation, use the following command:
more info here |
Sphinx was not compiling the documentation due a typo in a date-tag directive
instead of
I've also found another docstring error inside of the add_shader_callback method. I fixed that in 0137643 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @devmessias , some minor typos. Rest everything looks okay.
memview(arr_buffer_uint8)[:] = new_data_uint8 | ||
|
||
There is a solution for uint8 rawarrays using just memview and cast | ||
methods. However, numpy comes to rescue and offers a simple and a more a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
methods. However, numpy comes to rescue and offers a simple and a more a | |
methods. However, numpy comes to rescue and offers a simple and a more |
Thank you @devmessias, merging! |
No description provided.