Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Summer of Code blog posts #476

Merged
merged 7 commits into from Jul 30, 2021

Conversation

devmessias
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #476 (c810a52) into master (f376819) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
+ Coverage   88.41%   88.53%   +0.11%     
==========================================
  Files          31       31              
  Lines        6519     6575      +56     
  Branches      782      787       +5     
==========================================
+ Hits         5764     5821      +57     
  Misses        535      535              
+ Partials      220      219       -1     
Impacted Files Coverage Δ
fury/shaders/base.py 91.37% <ø> (ø)
fury/ui/tests/test_helpers.py 100.00% <0.00%> (ø)
fury/ui/helpers.py 98.21% <0.00%> (+5.35%) ⬆️

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devmessias,

The docs can not be generated. There are some issues in your blog post. Please can you generate the documentation locally, get a look and fix it. Thanks!

Can you also review this PR @SunTzunami and @antrikshmisri?
Thank you

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more comments

@SunTzunami
Copy link
Member

Hi @devmessias! It's quite a detailed blog with nice explanations. A few typos need to be fixed and the links seem to be breaking probably due to incorrect rst syntax, please rectify that and it'll be good.

@devmessias
Copy link
Contributor Author

Hi @devmessias,

The docs can not be generated. There are some issues in your blog post. Please can you generate the documentation locally, get a look and fix it. Thanks!

Can you also review this PR @SunTzunami and @antrikshmisri?
Thank you

Thanks @skoudoro and @SunTzunami

I need to rebase this

generating gallery for auto_examples... [100%] viz_network_animated.py                                                                                
generating gallery for auto_examples/physics_using_pybullet... [100%] viz_wrecking_ball.py                                                            

Extension error:
Handler <function generate_gallery_rst at 0x7f8ed9f60160> for event 'builder-inited' threw an exception (exception: [Errno 2] No such file or directory: '/home/devmessias/phd/fury/docs/source/auto_examples/viz_play_video.ipynb')

@skoudoro
Copy link
Contributor

skoudoro commented Jul 28, 2021

if you have issue with the examples/tutorials during the generation, use the following command:

$ make -C . clean && make -C . html-no-examples

more info here

@devmessias
Copy link
Contributor Author

if you have issue with the examples/tutorials during the generation, use the following command:

$ make -C . clean && make -C . html-no-examples

more info here

Sphinx was not compiling the documentation due a typo in a date-tag directive

.. post:: Jully ...

instead of

.. post:: July ..

I've also found another docstring error inside of the add_shader_callback method. I fixed that in 0137643

Copy link
Member

@antrikshmisri antrikshmisri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devmessias , some minor typos. Rest everything looks okay.

memview(arr_buffer_uint8)[:] = new_data_uint8

There is a solution for uint8 rawarrays using just memview and cast
methods. However, numpy comes to rescue and offers a simple and a more a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
methods. However, numpy comes to rescue and offers a simple and a more a
methods. However, numpy comes to rescue and offers a simple and a more

docs/source/posts/2021/2021-06-21-gsoc-devmessias-3.rst Outdated Show resolved Hide resolved
docs/source/posts/2021/2021-06-28-gsoc-devmessias-4.rst Outdated Show resolved Hide resolved
@skoudoro
Copy link
Contributor

Thank you @devmessias, merging!

@skoudoro skoudoro merged commit b0c4924 into fury-gl:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants