New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC blogs 2021 #493
GSoC blogs 2021 #493
Conversation
Weekly Check-in #1 (community bonding period)
Co-authored-by: Antriksh Misri <54466356+antrikshmisri@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SunTzunami,
Overall, it looks good. Some rendering are a bit weird so can you generate the doc locally and fix them?
Thank you
@@ -0,0 +1,44 @@ | |||
Eighth week of coding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coding week
instead of week of coding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
- **Ribbon representation:** https://github.com/fury-gl/fury/pull/452 | ||
- **Ribbon Representation demo:** https://github.com/fury-gl/fury/pull/452 | ||
|
||
- **Ball and Stick Representation** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange rendering here.
Maybe it is missing one empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added empty lines
What did you do this week? | ||
-------------------------- | ||
|
||
#. Updated `PR #452`_: Had an extra meeting with the mentors in which we fine-tuned the molecular module and optimised the code to make it more pythonic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird rendering, to update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Hi @skoudoro ! I updated the blogs and they look fine locally, PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 88.57% 88.96% +0.39%
==========================================
Files 31 33 +2
Lines 6597 7070 +473
Branches 791 832 +41
==========================================
+ Hits 5843 6290 +447
- Misses 535 547 +12
- Partials 219 233 +14
|
As you can see above, there are still some issues @SunTzunami . PTAL. |
Hi @skoudoro ! It looks fine locally: |
How do you generate the docs? in your screenshot, can you please add the menu on the right. I will try to clean my repo and try to regenerate it from my side too |
Hi @skoudoro , I use this command to generate docs: I'm not sure about which menu did you mean (the menu is on the left for me). Preview: |
Strange, I did exactly the same thing and I do not get the same rendering. What is your sphinx version? ( me, I get this:
Edit: Menu on the left indeed |
|
ok, strange, I updated my environment but I still can not get your result. I think it is from my side. I will go ahead and merge your PR. Thank you! |
GSoC Blogs for weeks 8, 9, 10 and final work product.