Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC blogs 2021 #493

Merged
merged 39 commits into from Sep 3, 2021
Merged

GSoC blogs 2021 #493

merged 39 commits into from Sep 3, 2021

Conversation

SunTzunami
Copy link
Member

GSoC Blogs for weeks 8, 9, 10 and final work product.

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SunTzunami,

Overall, it looks good. Some rendering are a bit weird so can you generate the doc locally and fix them?

Thank you

@@ -0,0 +1,44 @@
Eighth week of coding!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coding week instead of week of coding

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 59 to 62
- **Ribbon representation:** https://github.com/fury-gl/fury/pull/452
- **Ribbon Representation demo:** https://github.com/fury-gl/fury/pull/452

- **Ball and Stick Representation**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange rendering here.

Maybe it is missing one empty line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added empty lines

What did you do this week?
--------------------------

#. Updated `PR #452`_: Had an extra meeting with the mentors in which we fine-tuned the molecular module and optimised the code to make it more pythonic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird rendering, to update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@SunTzunami
Copy link
Member Author

Hi @skoudoro ! I updated the blogs and they look fine locally, PTAL.

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #493 (d891dce) into master (fedfd68) will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   88.57%   88.96%   +0.39%     
==========================================
  Files          31       33       +2     
  Lines        6597     7070     +473     
  Branches      791      832      +41     
==========================================
+ Hits         5843     6290     +447     
- Misses        535      547      +12     
- Partials      219      233      +14     
Impacted Files Coverage Δ
fury/utils.py 85.85% <0.00%> (-0.70%) ⬇️
fury/shaders/__init__.py 100.00% <0.00%> (ø)
fury/actors/tests/test_peak.py 97.95% <0.00%> (ø)
fury/actors/peak.py 90.00% <0.00%> (ø)
fury/shaders/base.py 91.54% <0.00%> (+0.16%) ⬆️
fury/primitive.py 92.13% <0.00%> (+0.35%) ⬆️
fury/actor.py 89.44% <0.00%> (+0.39%) ⬆️
fury/window.py 81.95% <0.00%> (+1.79%) ⬆️

@skoudoro
Copy link
Contributor

skoudoro commented Sep 3, 2021

Capture d’écran 2021-09-03 à 13 01 09

As you can see above, there are still some issues @SunTzunami . PTAL.

@SunTzunami
Copy link
Member Author

Hi @skoudoro ! It looks fine locally:

blog

@skoudoro
Copy link
Contributor

skoudoro commented Sep 3, 2021

How do you generate the docs? in your screenshot, can you please add the menu on the right. I will try to clean my repo and try to regenerate it from my side too

@SunTzunami
Copy link
Member Author

Hi @skoudoro , I use this command to generate docs: make -C . clean && make -C . html-no-examples.

I'm not sure about which menu did you mean (the menu is on the left for me).

Preview:

blogs

@skoudoro
Copy link
Contributor

skoudoro commented Sep 3, 2021

Strange, I did exactly the same thing and I do not get the same rendering.

What is your sphinx version? (pip show sphinx)

me, I get this:

(fury-env-37) MacBook-Pro-de-koudoro:docs koudoro$ pip show sphinx
Name: Sphinx
Version: 2.2.0
Summary: Python documentation generator
Home-page: http://sphinx-doc.org/
Author: Georg Brandl
Author-email: georg@python.org
License: BSD
Location: /Users/koudoro/miniconda3/envs/fury-env-37/lib/python3.7/site-packages
Requires: packaging, sphinxcontrib-serializinghtml, Pygments, setuptools, sphinxcontrib-devhelp, sphinxcontrib-htmlhelp, snowballstemmer, sphinxcontrib-qthelp, Jinja2, sphinxcontrib-applehelp, alabaster, babel, requests, sphinxcontrib-jsmath, imagesize, docutils
Required-by: 

Edit: Menu on the left indeed

@SunTzunami
Copy link
Member Author

Version: 4.1.2
Summary: Python documentation generator
Home-page: https://sphinx-doc.org/
Author: Georg Brandl
Author-email: georg@python.org
License: BSD
Location: /home/suntzunami/anaconda3/envs/env_fury/lib/python3.8/site-packages
Requires: sphinxcontrib-qthelp, sphinxcontrib-devhelp, docutils, sphinxcontrib-serializinghtml, Jinja2, imagesize, setuptools, sphinxcontrib-jsmath, packaging, requests, sphinxcontrib-applehelp, Pygments, snowballstemmer, babel, alabaster, sphinxcontrib-htmlhelp
Required-by: sphinx-rtd-theme, sphinx-gallery, sphinx-copybutton, ablog```

@skoudoro
Copy link
Contributor

skoudoro commented Sep 3, 2021

ok, strange, I updated my environment but I still can not get your result. I think it is from my side.

I will go ahead and merge your PR. Thank you!

@skoudoro skoudoro marked this pull request as ready for review September 3, 2021 19:03
@skoudoro skoudoro merged commit 480d0e5 into fury-gl:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants