Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disk position outside the slider line #498

Merged
merged 1 commit into from Sep 9, 2021

Conversation

guaje
Copy link
Contributor

@guaje guaje commented Sep 9, 2021

This PR fixes DIPY #2441 and similar problems with the slider.

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #498 (3ae0656) into master (dcfbfa1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files          33       33           
  Lines        7092     7093    +1     
  Branches      834      834           
=======================================
+ Hits         6312     6313    +1     
  Misses        547      547           
  Partials      233      233           
Impacted Files Coverage Δ
fury/ui/elements.py 88.55% <100.00%> (+<0.01%) ⬆️

@Garyfallidis
Copy link
Contributor

Thank you @guaje!

@Garyfallidis Garyfallidis merged commit ffee0a6 into fury-gl:master Sep 9, 2021
@guaje guaje deleted the fix_slider_length branch September 10, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizon error - disk position outside the slider line
2 participants