Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devmessias gsoc posts part 2: weeks 09, 10 and 11 #503

Merged
merged 8 commits into from Jan 27, 2022

Conversation

devmessias
Copy link
Contributor

No description provided.

@devmessias devmessias changed the title devmessias gsoc posts part 2: weeks 09, 10 and 11 [W.I.P.] devmessias gsoc posts part 2: weeks 09, 10 and 11 Sep 26, 2021
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #503 (3045eae) into master (2a1b5a3) will decrease coverage by 6.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   88.60%   81.89%   -6.72%     
==========================================
  Files          31       54      +23     
  Lines        6617    10659    +4042     
  Branches      794     1067     +273     
==========================================
+ Hits         5863     8729    +2866     
- Misses        535     1667    +1132     
- Partials      219      263      +44     
Impacted Files Coverage Δ
fury/actor.py
fury/shaders/__init__.py
fury/shaders/base.py
fury/utils.py
fury/window.py
fury/shaders/tests/test_base.py
fury/convert.py
fury/interactor.py
fury/material.py
fury/ui/helpers.py
... and 75 more

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devmessias,

Thank you for this PR. Do not forget to add the blog headers on each post. See below the error I got:

/Users/koudoro/Software/fury/docs/source/posts/2021/2021-06-28-gsoc-devmessias-4.rst:65: WARNING: Error in "code-block" directive:
maximum 1 argument(s) allowed, 6 supplied.

.. code-block:: python
   from abc import ABC, abstractmethod

   GenericImageBufferManager(ABC):
       def __init__(
               self, max_window_size=None, num_buffers=2, use_shared_mem=False):
            ...
       @abstractmethod
       def load_mem_resource(self):
           pass
       @abstractmethod
       def create_mem_resource(self):
           pass
       @abstractmethod
       def cleanup(self):
           pass
/Users/koudoro/Software/fury/docs/source/posts/2021/2021-07-05-gsoc-devmessias-5.rst:35: WARNING: Bullet list ends without a blank line; unexpected unindent.
/Users/koudoro/Software/fury/docs/source/posts/2021/2021-07-05-gsoc-devmessias-5.rst:38: WARNING: Bullet list ends without a blank line; unexpected unindent.
/Users/koudoro/Software/fury/docs/source/posts/2021/2021-07-05-gsoc-devmessias-5.rst:43: WARNING: Bullet list ends without a blank line; unexpected unindent.
/Users/koudoro/Software/fury/docs/source/posts/2021/2021-07-26-gsoc-devmessias-8.rst:19: WARNING: Bullet list ends without a blank line; unexpected unindent.
/Users/koudoro/Software/fury/docs/source/posts/2021/2021-08-23-gsoc-devmessias-final-report.rst:335: WARNING: Unexpected indentation.
/Users/koudoro/Software/fury/docs/source/posts/2021/2021-08-23-gsoc-devmessias-final-report.rst:334: WARNING: Inline interpreted text or phrase reference start-string without end-string.
/Users/koudoro/Software/fury/docs/source/posts/2021/2021-08-23-gsoc-devmessias-final-report.rst:337: WARNING: Block quote ends without a blank line; unexpected unindent.

visualization. Because I am doing my Ph.D. in a developing country I
always need to think of the less expensive solutions to use the
computational resources available. For example, with the GPU’s prices
increasing, it is necessary to share the a single machine with GPU
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove a

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, see above

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devmessias,

Can you finalize this? The new GSOC season will start and we would like all the previous session reports.

  • Some headers are missing
  • final report is duplicated
  • Seems to miss some weeks, I see only the 11, missing 9-10

Thanks

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @devmessias.

See below for some quick fixes. I will generate the page now to see if the rendering is ok.

@@ -0,0 +1,52 @@
Week #11: Welcome to my weekly Blogs!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10 instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also update the title?

@@ -0,0 +1,52 @@
Week #11: Welcome to my weekly Blogs!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9 instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also update the title?

Week #11: Welcome to my weekly Blogs!
====================================

.. post:: August 16 2021
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

August 2 instead

visualization. Because I am doing my Ph.D. in a developing country I
always need to think of the less expensive solutions to use the
computational resources available. For example, with the GPU’s prices
increasing, it is necessary to share the a single machine with GPU
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, see above

docs/source/posts/2021/2021-09-08-gsoc-devmessias-10.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devmessias,

It is close to being done:

  • Can you update the title of the different blog post. (they are all the same)
  • final report is not generated because it is missing the header
  • styling issue (week 11). Can you fix it? see below:

Capture d’écran 2022-01-24 à 17 40 13

@skoudoro skoudoro changed the title [W.I.P.] devmessias gsoc posts part 2: weeks 09, 10 and 11 devmessias gsoc posts part 2: weeks 09, 10 and 11 Jan 27, 2022
@skoudoro
Copy link
Contributor

Thank you for all those updates @devmessias. This is ready to go. Merging!

@skoudoro skoudoro merged commit 214375b into fury-gl:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants