Deprecate and rename label to vector_text #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 81.86% 81.87%
=======================================
Files 54 54
Lines 10616 10618 +2
Branches 1069 1069
=======================================
+ Hits 8691 8693 +2
Misses 1661 1661
Partials 264 264
|
skoudoro
force-pushed
the
deprecate_label
branch
from
9fa2e65
to
c28fbcf
Compare
fury/tests/test_actors.py
Outdated
| @@ -804,7 +804,8 @@ def test_points(interactive=False): | |||
|
|
|||
|
|
|||
| def test_labels(interactive=False): | |||
| text_actor = actor.label("Hello") | |||
| npt.assert_warns(DeprecationWarning, actor.label, "hello") | |||
|
One of the tests is failing in relation to slicer I think. Can you check? Is that a random error? |
skoudoro
force-pushed
the
deprecate_label
branch
from
e0106e7
to
a2f7e1b
Compare
skoudoro
force-pushed
the
deprecate_label
branch
from
a2f7e1b
to
b8cf732
Compare
|
All green! Let's go! Merging ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of this comment from #489.
The goal is to:
label(...)tovector_text(...)labeland warn the users of the change