Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Radio button and checkbox tests #514

Merged
merged 4 commits into from Dec 16, 2021
Merged

[FIX] Radio button and checkbox tests #514

merged 4 commits into from Dec 16, 2021

Conversation

skoudoro
Copy link
Contributor

@skoudoro skoudoro commented Dec 15, 2021 •
edited

This PR update some tests that were failing often:

  • radio button (tests needed to be recorded again)
  • checkbox (tests needed to be recorded again)
  • *.tif format on IO

It should fix Windows and MacOSx CIs

@pep8speaks
Copy link

pep8speaks commented Dec 15, 2021 •
edited

Hello @skoudoro! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-12-16 14:02:26 UTC

@Garyfallidis
Copy link
Contributor

Windows and Mac okay. Linux is next!

@Garyfallidis Garyfallidis merged commit 86b3a49 into fury-gl:master Dec 16, 2021
@skoudoro skoudoro deleted the fix-recording branch December 16, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skoudoro @pep8speaks @Garyfallidis