Principled material #519
Merged
Principled material #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # fury/material.py
|
@guaje please add a simple tutorial to help the review process. |
@Garyfallidis I have added a small demo showing how to use the new material and the effects of each parameter. |
|
Great work @guaje! Will merge this now so that you can move ahead with the next steps including IBL and other shading techniques. Do check back on these tests after #518 is merged too. 518 is creating a temporarily solution until pytests/vtk solve a potential threading issue that break our testing platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings Burley's et al. principled BRDF to FURY.