Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added play/pause buttons #577

Merged

Conversation

lej0hn
Copy link
Contributor

@lej0hn lej0hn commented Apr 19, 2022

Implemented the ability to pause and resume the animation with the use of buttons.

@pep8speaks
Copy link

pep8speaks commented Apr 19, 2022

Hello @lej0hn! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-19 16:52:44 UTC

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #577 (4304e93) into master (dadbb8e) will increase coverage by 0.26%.
The diff coverage is n/a.

❗ Current head 4304e93 differs from pull request most recent head 63aed77. Consider uploading reports for the commit 63aed77 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   88.61%   88.88%   +0.26%     
==========================================
  Files          55       55              
  Lines       10953    11367     +414     
  Branches     1080     1120      +40     
==========================================
+ Hits         9706    10103     +397     
- Misses        952      965      +13     
- Partials      295      299       +4     
Impacted Files Coverage Δ
fury/fury/data/fetcher.py 71.03% <0.00%> (-1.38%) ⬇️
fury/fury/layout.py 98.63% <0.00%> (-1.37%) ⬇️
fury/fury/io.py 81.46% <0.00%> (-0.93%) ⬇️
fury/fury/tests/test_utils.py 94.26% <0.00%> (-0.74%) ⬇️
fury/fury/actor.py 88.15% <0.00%> (-0.17%) ⬇️
fury/fury/lib.py 100.00% <0.00%> (ø)
fury/fury/ui/helpers.py 98.21% <0.00%> (ø)
fury/fury/tests/test_layout.py 100.00% <0.00%> (ø)
fury/fury/tests/test_material.py 100.00% <0.00%> (ø)
fury/fury/tests/test_primitive.py 100.00% <0.00%> (ø)
... and 7 more

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lej0hn,

Can you address all the pep8 issues? thank you for adding this feature!

@lej0hn
Copy link
Contributor Author

lej0hn commented Apr 19, 2022

Hi @skoudoro ,
All pep8 issues have been resolved!

@skoudoro
Copy link
Contributor

Thank you for the update. Looks good, merging.

@skoudoro skoudoro merged commit 24eddc7 into fury-gl:master Apr 19, 2022
@lej0hn lej0hn deleted the tutorials/solar_system/add-play-pause-buttons branch April 19, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants