Keep original dtype for offsets in vtk format #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
reviewed
May 23, 2022
skoudoro
requested changes
Jun 7, 2022
There was a problem hiding this comment.
Hi @frheault,
With this change, We encounter many times and at different places the following error:
2022-05-25 16:41:51.973 ( 1.931s) [ 69E6D740] vtkCellArray.cxx:908 ERR| vtkCellArray (0x5566eb83e3c0): Invalid array types passed to SetData: offsets=vtkUnsignedLongLongArray, connectivity=vtkUnsignedLongLongArrayCan you look at it and run the tests locally.
Thanks !
|
@skoudoro can you activate tests on both PR, I think they should run now. |
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
==========================================
- Coverage 87.94% 87.91% -0.03%
==========================================
Files 62 62
Lines 13099 13104 +5
Branches 1316 1318 +2
==========================================
+ Hits 11520 11521 +1
- Misses 1202 1205 +3
- Partials 377 378 +1
|
|
Thank you @frheault, merging. We plan to do a release by the end of this month (June) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows saving VTK using offsets as int32 or int64 by keeping the initial datatype rather than casting it to int64.
Since the ArraySequence as offsets as int64 for default, this does not change the current behavior of the stateful_tractogram in DiPy.
@arokem (this PR match the one I made today in Dipy, to solve limitation with VTK for Chris' Benchmarking)