Creating `DrawPanel` UI #599

ganimtron-10 · 2022-06-09T06:38:35Z

This UI would help us to create various shapes and transform them.

Currently, it supports

Creation of
- Line
- Circle
- Quad
Selection (Translation)
Deletion
Shapes are perfectly clamped

Demo

codecov · 2022-06-09T06:46:23Z

Codecov Report

Merging #599 (24412af) into master (01a7ce2) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 24412af differs from pull request most recent head 18fb1b8. Consider uploading reports for the commit 18fb1b8 to get more accurate results

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   87.93%   87.98%   +0.04%     
==========================================
  Files          62       62              
  Lines       13126    13342     +216     
  Branches     1322     1355      +33     
==========================================
+ Hits        11543    11739     +196     
- Misses       1206     1216      +10     
- Partials      377      387      +10

Impacted Files	Coverage Δ
fury/fury/stream/tools.py	`90.94% <0.00%> (-0.22%)`	⬇️
fury/fury/ui/elements.py	`87.64% <0.00%> (+0.34%)`	⬆️
fury/fury/ui/tests/test_elements.py	`74.76% <0.00%> (+0.82%)`	⬆️
fury/fury/data/fetcher.py	`72.66% <0.00%> (+2.66%)`	⬆️

skoudoro

Hi @ganimtron-10,

Thank you for this feature. This is really nice! see below for some comments.

it would be also good :

if you could add the erase functionality
To add an option to tell if DrawPanel is movable or not
When we start, we see mode selection, but nothing happens when we click the drawer panel, it is confusing. it will be good to do something.
it would be good to use the on/off capabilities of button2D to know which tool we are using

docs/tutorials/02_ui/viz_drawpanel.py

fury/ui/elements.py

m-agour · 2022-06-09T21:48:20Z

Hello @ganimtron-10 ,
Great job you did there! It's really nice to draw primitives like that, maybe for describing a scene or draw an arrow to point at something and a lot of other useful applications.

I experimented with the panel, and I have found some minor glitches:

when I click in place in drawing mode, it draws a time point which does not get rendered until I draw a big shape or force render the scene somehow (I'm not sure if it should be allowed to draw shapes in place unless I'm drawing a point).

2022-06-09.23-26-21.mp4

The above issue also triggered the below runtime warning:

 ..\fury\fury\ui\elements.py:3149: RuntimeWarning: divide by zero encountered in long_scalars
  self.rotate_line(deg=np.arctan(size[1]/size[0]))

Another minor note is there should be a separate selection mode and selecting shapes while drawing should be disabled or handled in another way, because in the current state I can't draw shapes above shapes.

xtanion

Hi @ganimtron-10, This feature is really nice and everything is working fine. There are a few runtime warnings I encountered, Look at my comment below.
Thanks.

fury/ui/elements.py

pep8speaks · 2022-06-10T14:26:49Z

Hello @ganimtron-10! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-30 16:10:30 UTC

ganimtron-10 · 2022-06-10T17:52:20Z

Thank You @m-agour and @xtanion for your wonderful review!!

fury/data/fetcher.py

…nto DrawPanel_UI

ganimtron-10 · 2022-06-24T08:50:56Z

Hello @Garyfallidis @nasimanousheh @skoudoro ,
I have updated the DrawPanel and DrawShape UI, due to which the shapes are now restricted to remain inside the canvas.
PTAL.

The tests are failing because I have separated the code for the fetcher function which fetches new icons required for the DrawPanel UI.

Thanks!

skoudoro

Hi @ganimtron-10,

This first version looks really good.

we can not test this tutorial because the fetcher is missing. Since the fetcher PR has been merged, Can you merge master or rebase this PR?

After that, and few other fixes, it should be ready to be merged. Thanks for this clean work

fury/ui/elements.py

skoudoro · 2022-06-24T23:23:04Z

fury/ui/elements.py

+        self.canvas.background.on_left_mouse_button_pressed = self.left_button_pressed
+        self.canvas.background.on_left_mouse_button_dragged = self.left_button_dragged
+
+        mode_data = {


can you note this somewhere as a future new feature

skoudoro · 2022-06-24T23:23:07Z

fury/ui/elements.py

+        }
+
+        padding = 5
+        mode_panel_size = (len(mode_data) * 35 + 2 * padding, 40)


can you note this somewhere as a future new feature

fury/ui/elements.py

…nto DrawPanel_UI

skoudoro

ok, LGTM! thanks @ganimtron-10!

This is ready to go. I will wait for another review until Wednesday. if no other review, I will go ahead and merge it.

I found one small bug but I think, this fix or any new features should be done in a new PR.

Good job!

fury/ui/elements.py

nasimanousheh · 2022-06-25T21:41:56Z

Hi @ganimtron-10. Great job! you fixed the boundary issue and by moving the shape, it doesn't go out of the canvas boundary.
I found two bugs in your recent changes:

I can not move the shape with one click. I need to double click on the shape to move it.
When I double click on the shape, without moving the mouse, the shape jumps to other position. As you see here:

ganimtron-10 · 2022-06-27T12:50:04Z

Hello @nasimanousheh ,

I can not move the shape with one click. I need to double click on the shape to move it.

When I use my external mouse single click with the dragging works pretty fine, but when I use my trackpad mouse I have to double click and then drag.

When I double click on the shape, without moving the mouse, the shape jumps to other position. As you see here:

There was an issue with the positioning of the element in the panel which is now fixed using relative positioning.

PTAL.

Thanks!

fury/ui/elements.py

Garyfallidis · 2022-06-30T21:17:12Z

Great job @ganimtron-10 ! Merging. Bring forth the titans aka next PRs!

ganimtron-10 added 7 commits June 3, 2022 13:59

implementing visualizer

2b2e490

adding and rotating line

e3807d0

creating Shape2d class

0a1e092

fixing pep

439cbba

adding docs

ea60539

adding tutorial

6c9cd13

renaming the class to DrawPanel

6ee06cd

ganimtron-10 marked this pull request as draft June 9, 2022 06:39

changing 'cur' to 'current'

9402b45

adding tests

1212f7f

skoudoro requested changes Jun 9, 2022

View reviewed changes

skoudoro added the type:New Feature label Jun 9, 2022

skoudoro requested review from m-agour and xtanion June 9, 2022 19:22

ganimtron-10 added 2 commits June 10, 2022 08:38

force_rendering where ever required

a32a236

doc change

992d841

xtanion reviewed Jun 10, 2022

View reviewed changes

fury/ui/elements.py Outdated Show resolved Hide resolved

ganimtron-10 added 2 commits June 10, 2022 19:48

adding docs and modifying code

d1e13bc

resolving division by zero warning

fd9416d

ganimtron-10 added 7 commits June 10, 2022 20:09

updating tutorial

23059cf

modifying start message

5449978

using icons for testing purpose

de33704

fixing pep

836c0de

removing external icons

9271b9c

updating tests

2f826b8

implementing deletion and enhancing interaction

d9d7d7a

updating icon integration

01aeaf0

m-agour reviewed Jun 17, 2022

View reviewed changes

fury/data/fetcher.py Outdated Show resolved Hide resolved

ganimtron-10 added 8 commits June 17, 2022 23:33

clamping mouse position while drawing

3effdce

updating tests

f4033ae

updating docs

d8b6bf6

removing fetcher code

ae432af

removing fetcher code

0e3ecee

Merge branch 'DrawPanel_UI' of https://github.com/ganimtron-10/fury i…

4a53368

…nto DrawPanel_UI

clamping shape position while translating

247e852

updating tests

841b04c

ganimtron-10 requested review from m-agour and xtanion June 24, 2022 08:51

updating docs

d9981d0

skoudoro reviewed Jun 24, 2022

View reviewed changes

ganimtron-10 and others added 3 commits June 25, 2022 10:36

Merge branch 'fury-gl:master' into DrawPanel_UI

82d2921

updating docs and imports

277b595

Merge branch 'DrawPanel_UI' of https://github.com/ganimtron-10/fury i…

282d114

…nto DrawPanel_UI

skoudoro approved these changes Jun 25, 2022

View reviewed changes

nasimanousheh approved these changes Jun 25, 2022

View reviewed changes

fury/ui/elements.py Show resolved Hide resolved

fixing automatic translating issue

8bf2529

updating tests

24412af

nasimanousheh reviewed Jun 30, 2022

View reviewed changes

fury/ui/elements.py Outdated Show resolved Hide resolved

fury/ui/elements.py Show resolved Hide resolved

fury/ui/elements.py Show resolved Hide resolved

fury/ui/elements.py Show resolved Hide resolved

fury/ui/elements.py Show resolved Hide resolved

ganimtron-10 added 2 commits June 30, 2022 21:32

updating docs and adding todos

f9073d9

fixing pep

18fb1b8

Garyfallidis merged commit f82e195 into fury-gl:master Jun 30, 2022

ganimtron-10 deleted the DrawPanel_UI branch August 7, 2022 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creating `DrawPanel` UI #599

Creating `DrawPanel` UI #599

ganimtron-10 commented Jun 9, 2022 •

edited

codecov bot commented Jun 9, 2022 •

edited

skoudoro left a comment

m-agour commented Jun 9, 2022

xtanion left a comment

pep8speaks commented Jun 10, 2022 •

edited

ganimtron-10 commented Jun 10, 2022

ganimtron-10 commented Jun 24, 2022

skoudoro left a comment

skoudoro Jun 24, 2022

skoudoro Jun 24, 2022

skoudoro left a comment

nasimanousheh commented Jun 25, 2022

ganimtron-10 commented Jun 27, 2022

Garyfallidis commented Jun 30, 2022

Creating DrawPanel UI #599

Creating DrawPanel UI #599

Conversation

ganimtron-10 commented Jun 9, 2022 • edited

codecov bot commented Jun 9, 2022 • edited

Codecov Report

skoudoro left a comment

Choose a reason for hiding this comment

m-agour commented Jun 9, 2022

xtanion left a comment

Choose a reason for hiding this comment

pep8speaks commented Jun 10, 2022 • edited

Comment last updated at 2022-06-30 16:10:30 UTC

ganimtron-10 commented Jun 10, 2022

ganimtron-10 commented Jun 24, 2022

skoudoro left a comment

Choose a reason for hiding this comment

skoudoro Jun 24, 2022

Choose a reason for hiding this comment

skoudoro Jun 24, 2022

Choose a reason for hiding this comment

skoudoro left a comment

Choose a reason for hiding this comment

nasimanousheh commented Jun 25, 2022

ganimtron-10 commented Jun 27, 2022

Garyfallidis commented Jun 30, 2022

Creating `DrawPanel` UI #599

Creating `DrawPanel` UI #599

ganimtron-10 commented Jun 9, 2022 •

edited

codecov bot commented Jun 9, 2022 •

edited

pep8speaks commented Jun 10, 2022 •

edited