Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Week1 Blog Post #605

Merged
merged 4 commits into from Jun 28, 2022
Merged

Adding Week1 Blog Post #605

merged 4 commits into from Jun 28, 2022

Conversation

ganimtron-10
Copy link
Contributor

Adding the blog post for the first week.
I have successfully generated the docs and here's the result

msedge_bqiBBcVV1M

msedge_gLf8wNVe65

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #605 (43fc63b) into master (c642951) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   87.96%   87.93%   -0.04%     
==========================================
  Files          62       62              
  Lines       13121    13126       +5     
  Branches     1320     1322       +2     
==========================================
  Hits        11542    11542              
- Misses       1202     1206       +4     
- Partials      377      378       +1     
Impacted Files Coverage Δ
fury/fury/data/fetcher.py 70.00% <0.00%> (-2.42%) ⬇️

Copy link
Member

@xtanion xtanion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ganimtron-10, Really nice blog. The doc is generating just fine. PTAL at my comments below.
Thanks.

docs/source/posts/2022/2022-06-08-week-1-praneeth.rst Outdated Show resolved Hide resolved
@skoudoro
Copy link
Contributor

We are waiting for your review @m-agour

@m-agour
Copy link
Contributor

m-agour commented Jun 27, 2022

We are waiting for your review @m-agour

@skoudoro I reviewed it when it got published and it was superb with no typos but forgot to comment that sorry, it was a crowded week.

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks @ganimtron-10! merging!

@skoudoro skoudoro merged commit 63b87a8 into fury-gl:master Jun 28, 2022
@ganimtron-10 ganimtron-10 deleted the blog_post branch June 29, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants