Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Week 6 Blogpost #638

Merged
merged 4 commits into from Jul 27, 2022
Merged

Adding Week 6 Blogpost #638

merged 4 commits into from Jul 27, 2022

Conversation

ganimtron-10
Copy link
Contributor

Adding Weekly Blogpost.

msedge_M5FpTfHo1P

m-agour
m-agour reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@m-agour m-agour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10,
The name 'Week 6' makes me and @xtanion look so lazy 🤣
Good job, there are no typos and it looks more like a blog post, mine looks more like a manifesto or something.
Please see my suggestions below.

xtanion
xtanion reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@xtanion xtanion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10, Nice bog. There's no typos or grammatical errors, good job 👍🏽

skoudoro
skoudoro requested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10,

Shorter are the sentences better and clearer it is. Some of your sentences are really to understand. either, there are too long, or either you use that or which in a strange way.

Can you update some sentences?

Thank you.

docs/source/posts/2022/2022-07-13-week-6-praneeth.rst Outdated Show resolved Hide resolved
@ganimtron-10
Copy link
Contributor Author

Thank You @skoudoro for the review.
I will consider these suggestions in my future blogs and try to improve them.

@ganimtron-10
Copy link
Contributor Author

Hello @skoudoro ,
Is there anything else left on this PR??
I have updated the post according to the required changes.
PTAL.
Thanks!

skoudoro
skoudoro approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, all good, merging

@skoudoro skoudoro merged commit 223a6a2 into fury-gl:master Jul 27, 2022
@ganimtron-10 ganimtron-10 deleted the week-6 branch August 7, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-agour m-agour m-agour left review comments

@xtanion xtanion xtanion left review comments

@skoudoro skoudoro skoudoro approved these changes

Assignees
No one assigned
Labels
type:Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ganimtron-10 @skoudoro @m-agour @xtanion