Week 6 blog post #641

m-agour · 2022-07-25T13:04:05Z

ganimtron-10

Hello @m-agour ,
(Welcome to Week 6 Party 🎉)
Nice Blog! I had a few suggestions mentioned below, PTAL.
Thanks!

ganimtron-10 · 2022-07-25T16:34:06Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+- Improved the ``PlaybackPanel`` by adding speed control and the ability to loop the animation. Also, fixed the lagging issue of play and pause buttons and composed them into a single play/pause button.
+
+- Updated the old tutorials' syntax to match the other tutorials and added a new tutorial on position animation using spline interpolation. And added unit tests for the ``PlaybackPanel`` and the newly added color converters in ``colormap.py``.


extra ' in tutorials'

ganimtron-10 · 2022-07-25T16:37:51Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+- Added more hooks to the 2D sliders to cover two more states: ``on_value_changed`` and ``on_moving_slider`` `#634`_.
+
+- Provided the ability to add static actors to the ``Timeline``, which might be needed in the animation part of shivam's glTF project.


maybe Shivam's

ganimtron-10 · 2022-07-25T16:42:34Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+- Improved the ``PlaybackPanel`` by adding speed control and the ability to loop the animation. Also, fixed the lagging issue of play and pause buttons and composed them into a single play/pause button.
+
+- Updated the old tutorials' syntax to match the other tutorials and added a new tutorial on position animation using spline interpolation. And added unit tests for the ``PlaybackPanel`` and the newly added color converters in ``colormap.py``.


I think these lines should be something like this
... spline interpolation and added unit tests ...
or
... spline interpolation. Added unit tests ...

xtanion

Hi @m-agour, Nice blog. I have a few small suggestions PTAL.
Thanks

xtanion · 2022-07-25T21:43:18Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+  - A custom evaluator uses a user-provided function that takes time as input and evaluates the property at that time. This feature is yet to be discussed more in today's meeting.
+
+- Fixed camera rotation, and view-up issue when interacting with the scene.


, not needed after rotation

xtanion · 2022-07-25T21:53:59Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+- Provided the ability to add static actors to the ``Timeline``, which might be needed in the animation part of shivam's glTF project.
+
+  - If an ``actor`` is added to the ``Timeline`` as a static actor, it won't be animated by the ``Timeline``, but it will get added to the scene along with the ``Timeline`` when the ``Timeline`` is added to the scene.


This sentence is too long. (for e.g. You can remove when the ``Timeline`` is added to the scene and it won't make much difference in the sentence)

m-agour · 2022-07-25T22:27:26Z

Thanks @ganimtron-10 and @xtanion so much for reviewing my blog post.

skoudoro · 2022-07-27T04:26:17Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+- Updated the old tutorials' syntax to match the other tutorials and added a new tutorial on position animation using spline interpolation. Added unit tests for the ``PlaybackPanel`` and the newly added color converters in ``colormap.py``.
+
+- Added more hooks to the 2D sliders to cover two more states: ``on_value_changed`` and ``on_moving_slider`` `#634`_.


What is difference? why do you need to add them? can you explain more here

skoudoro · 2022-07-27T04:26:58Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+- Added more hooks to the 2D sliders to cover two more states: ``on_value_changed`` and ``on_moving_slider`` `#634`_.
+
+- Provided the ability to add static actors to the ``Timeline``, which might be needed in the animation part of Shivam's glTF project.


Shivam's glTF project

add a link

skoudoro · 2022-07-27T04:28:09Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+What is coming up next week?
+----------------------------
+Next week's work is yet to be determined.


it seems you can update now

codecov · 2022-07-28T13:30:23Z

Codecov Report

Merging #641 (e570d71) into master (bca7b33) will decrease coverage by 1.02%.
The diff coverage is 0.00%.

❗ Current head e570d71 differs from pull request most recent head 8aa49c1. Consider uploading reports for the commit 8aa49c1 to get more accurate results

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage   52.04%   51.02%   -1.03%     
==========================================
  Files         108      108              
  Lines       23812    23818       +6     
  Branches     2631     2631              
==========================================
- Hits        12394    12152     -242     
- Misses      11013    11256     +243     
- Partials      405      410       +5

Impacted Files	Coverage Δ
fury/ui/tests/test_containers.py	`0.00% <0.00%> (ø)`
fury/fury/tests/test_window.py	`50.94% <0.00%> (-35.43%)`	⬇️
fury/fury/ui/tests/test_containers.py	`64.76% <0.00%> (-28.96%)`	⬇️
fury/fury/window.py	`72.85% <0.00%> (-10.41%)`	⬇️
fury/fury/shaders/base.py	`84.84% <0.00%> (-8.09%)`	⬇️
fury/fury/ui/containers.py	`82.92% <0.00%> (-0.89%)`	⬇️
fury/fury/data/fetcher.py	`67.81% <0.00%> (-0.43%)`	⬇️
fury/fury/actor.py	`88.87% <0.00%> (-0.19%)`	⬇️
fury/fury/tests/test_interactor.py	`89.76% <0.00%> (+0.08%)`	⬆️
fury/fury/tests/test_actors.py	`91.65% <0.00%> (+0.09%)`	⬆️
... and 1 more

skoudoro

Thank you for the update @m-agour.

See below my last comment

skoudoro · 2022-07-28T14:29:34Z

docs/source/posts/2022/2022-07-25-week-6-mohamed.rst

+
+  - The reason for adding these two hooks is that there was only the ``on_change`` hook, which always gets called when the value of the slider is changed without considering how the value is changed, hence, the functionality of the slider was limited.
+
+- Provided the ability to add static actors to the ``Timeline``, which might be needed in the animation part of Shivam's glTF project `#634`_.


skoudoro · 2022-07-28T14:34:19Z

Thank you for the update @m-agour, merging

m-agour · 2022-07-28T14:34:47Z

Thank you @skoudoro

m-agour added 2 commits July 25, 2022 14:53

Added week 6 blog post

b33ce65

Fixed formatting issues

da0838d

ganimtron-10 added the type:Documentation label Jul 25, 2022

ganimtron-10 reviewed Jul 25, 2022

View reviewed changes

xtanion reviewed Jul 25, 2022

View reviewed changes

Modified my blog post according to @ganimtron-10 and @xtanion reviews.

b8efd35

skoudoro reviewed Jul 27, 2022

View reviewed changes

Updated the post according to @skoudoro review

e570d71

skoudoro reviewed Jul 28, 2022

View reviewed changes

Wrong link fixed

8aa49c1

skoudoro merged commit 2ac1bb3 into fury-gl:master Jul 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Week 6 blog post #641

Week 6 blog post #641

m-agour commented Jul 25, 2022

ganimtron-10 left a comment

ganimtron-10 Jul 25, 2022

ganimtron-10 Jul 25, 2022

ganimtron-10 Jul 25, 2022

xtanion left a comment

xtanion Jul 25, 2022

xtanion Jul 25, 2022

m-agour commented Jul 25, 2022

skoudoro Jul 27, 2022

skoudoro Jul 27, 2022

skoudoro Jul 27, 2022

codecov bot commented Jul 28, 2022 •

edited

skoudoro left a comment

skoudoro Jul 28, 2022

skoudoro commented Jul 28, 2022

m-agour commented Jul 28, 2022


		- Improved the ``PlaybackPanel`` by adding speed control and the ability to loop the animation. Also, fixed the lagging issue of play and pause buttons and composed them into a single play/pause button.

		- Updated the old tutorials' syntax to match the other tutorials and added a new tutorial on position animation using spline interpolation. And added unit tests for the ``PlaybackPanel`` and the newly added color converters in ``colormap.py``.


		- Added more hooks to the 2D sliders to cover two more states: ``on_value_changed`` and ``on_moving_slider`` `#634`_.

		- Provided the ability to add static actors to the ``Timeline``, which might be needed in the animation part of shivam's glTF project.


		- A custom evaluator uses a user-provided function that takes time as input and evaluates the property at that time. This feature is yet to be discussed more in today's meeting.

		- Fixed camera rotation, and view-up issue when interacting with the scene.


		- Provided the ability to add static actors to the ``Timeline``, which might be needed in the animation part of shivam's glTF project.

		- If an ``actor`` is added to the ``Timeline`` as a static actor, it won't be animated by the ``Timeline``, but it will get added to the scene along with the ``Timeline`` when the ``Timeline`` is added to the scene.


		- The reason for adding these two hooks is that there was only the ``on_change`` hook, which always gets called when the value of the slider is changed without considering how the value is changed, hence, the functionality of the slider was limited.

		- Provided the ability to add static actors to the ``Timeline``, which might be needed in the animation part of Shivam's glTF project `#634`_.

Week 6 blog post #641

Week 6 blog post #641

Conversation

m-agour commented Jul 25, 2022

ganimtron-10 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xtanion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-agour commented Jul 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 28, 2022 • edited

Codecov Report

skoudoro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skoudoro commented Jul 28, 2022

m-agour commented Jul 28, 2022

codecov bot commented Jul 28, 2022 •

edited