Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Week 9 Blogpost #654

Merged
merged 4 commits into from Aug 17, 2022
Merged

Adding Week 9 Blogpost #654

merged 4 commits into from Aug 17, 2022

Conversation

ganimtron-10
Copy link
Contributor

Adding Weekly Blogpost

msedge_6sB1Wv5jAC

@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #654 (916fcf2) into master (2b2caf8) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   51.02%   51.35%   +0.32%     
==========================================
  Files         108      108              
  Lines       23818    23882      +64     
  Branches     2631     2631              
==========================================
+ Hits        12153    12264     +111     
+ Misses      11256    11208      -48     
- Partials      409      410       +1     
Impacted Files Coverage Δ
fury/ui/elements.py 0.00% <0.00%> (ø)
fury/ui/tests/test_elements.py 0.00% <0.00%> (ø)
fury/fury/ui/elements.py 90.26% <0.00%> (+0.07%) ⬆️
fury/fury/window.py 73.98% <0.00%> (+1.13%) ⬆️
fury/fury/ui/tests/test_elements.py 79.27% <0.00%> (+1.45%) ⬆️
fury/fury/tests/test_window.py 71.42% <0.00%> (+20.48%) ⬆️

Copy link
Contributor

@m-agour m-agour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ganimtron-10,
Please see my comments below
Thanks

docs/source/posts/2022/2022-08-03-week-9-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-08-03-week-9-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-08-03-week-9-praneeth.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is your review @xtanion?

@ganimtron-10, can you address @m-agour comments?

docs/source/posts/2022/2022-08-03-week-9-praneeth.rst Outdated Show resolved Hide resolved
Copy link
Member

@xtanion xtanion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice blog @ganimtron-10 , PTAL at my comment below

docs/source/posts/2022/2022-08-03-week-9-praneeth.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @ganimtron-10, and for all the reviews. Merging!

@skoudoro skoudoro merged commit 8ba8ea9 into fury-gl:master Aug 17, 2022
@ganimtron-10 ganimtron-10 deleted the week-9 branch August 18, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants