New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week 11 blog post #675
Week 11 blog post #675
Conversation
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
- Coverage 50.40% 50.39% -0.01%
==========================================
Files 120 120
Lines 26980 26980
Branches 2986 2986
==========================================
- Hits 13598 13597 -1
Misses 12923 12923
- Partials 459 460 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Blog @m-agour ,
PTAL at my below comments.
Thanks!
|
||
- Find out how to get the ``Scene`` from the actor instead of manually assigning it. | ||
|
||
- If I have time, I will try implement recording animation as GIF or as a video. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to implement
instead
|
||
- Fixed some issues in the hierarchical order animation support `PR`_ that we discussed during last week's meeting (mostly naming issues). | ||
|
||
- Explained the introductory tutorial a little. But it is not good suitable beginners. So, I will spend time improving tutorials this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add for
or rephrase the sentence
something like But it is not good for beginners.
Ohh Sorry I just saw this PR is still a draft! |
It's okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice blog post @m-agour, No typos or any grammatical mistakes. PTAL at my suggestion below.
|
||
- Added extrusion to `vector_text`_ to allow the z-scaling to be functional. | ||
|
||
- Fixed ``lightColor0`` being `hard-set`_ to ``(1, 1, 1)``. Instead, it's now using the ``Scene`` to set the lighting uniforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses
instead of It's now using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below my comment. after this fix, it is ready to go. please answer to @xtanion also
What did you do this week? | ||
-------------------------- | ||
|
||
This week I didn't do much work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to be honest but not sure we want to read this without explanation. so either explain or remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skoudoro done
thank you for the update, merging |
My blog post for week 11