Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Week 13 Blogpost #683

Merged
merged 2 commits into from Sep 15, 2022
Merged

Adding Week 13 Blogpost #683

merged 2 commits into from Sep 15, 2022

Conversation

ganimtron-10
Copy link
Contributor

Adding weekly post

image

@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #683 (ad9af4e) into master (054d709) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   50.41%   50.41%   -0.01%     
==========================================
  Files         120      120              
  Lines       27160    27160              
  Branches     3001     3001              
==========================================
- Hits        13693    13692       -1     
  Misses      13006    13006              
- Partials      461      462       +1     
Impacted Files Coverage Δ
fury/fury/stream/tools.py 90.94% <0.00%> (-0.22%) ⬇️

@skoudoro
Copy link
Contributor

@xtanion ???

Copy link
Member

@xtanion xtanion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10, Nice blog. A few commas are missing.
PTAL at my comments below.

docs/source/posts/2022/2022-08-31-week-13-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-08-31-week-13-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-08-31-week-13-praneeth.rst Outdated Show resolved Hide resolved
@skoudoro
Copy link
Contributor

@ganimtron-10 ?

@ganimtron-10
Copy link
Contributor Author

Hello @skoudoro ,
Sorry for the delay I have updated the posts!!

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @ganimtron-10,

See below the last comments

@skoudoro
Copy link
Contributor

LGTM! Thank you @ganimtron-10, merging

@skoudoro skoudoro merged commit 0384dbb into fury-gl:master Sep 15, 2022
@ganimtron-10 ganimtron-10 deleted the week-13 branch September 16, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants