New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding week 14 blog #697
Adding week 14 blog #697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @xtanion ,
Good work, and good blog post. Please see my comments below, thanks.
What did you do this week? | ||
-------------------------- | ||
|
||
- This week, I started with Multiple actor support in skinning, Managed to do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be: , and managed ...
|
||
- Creating a PR for morphing code. | ||
|
||
- Multi primitive(actor) support in morphing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe missing a space primitive (actor)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @xtanion ,
PTAL at the below comments.
Thanks!
|
||
- We merged two PRs, `#689`_ (colors from Material) and `#643`_ (simple animations). | ||
|
||
- Added ability to load morphing information and create timelines from it. Here's a preview of the ``AnimatedMorphCube`` and ``AnimatedMorphSphere``models: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space between AnimatedMorphSphere
and models:
-------------------------- | ||
|
||
- This week, I started with Multiple actor support in skinning, Managed to do it | ||
successfully (see brainStem Model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if you either add a link to the video to see the brainStem working in the fury or directly integrate the video here itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, I'll add it
-------------------------- | ||
|
||
- This week, I started with Multiple actor support in skinning, Managed to do it | ||
successfully (see brainStem Model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BrainStem
instead
- This week, I started with Multiple actor support in skinning, Managed to do it | ||
successfully (see brainStem Model) | ||
|
||
- Implementing multiple animation channels support (as seen in the ``Fox`` model). The ``get_skin_timelines()`` method now returns a dictionary of all animation channels with Timeline as their value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
Add a link to a video or add it here so that reader would get an idea about what you are specifying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple animation channels are in the Fox model itself, maybe adding the link to the Fox model can help
|
||
.. raw:: html | ||
|
||
<iframe id="player" type="text/html" width="1280" height="720" src="https://user-images.githubusercontent.com/74976752/192871376-881fbdd6-2fab-4a7f-9f4f-07663d93561c.mp4" frameborder="0"></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xtanion,
Your videos are too big, we need to scroll and it is hard to understand what is going on.
You might need to record them again with a smaller resolution to fit the blog post. Otherwise, you can find a trick to scale them down.
Apart from that, all is good. Let me know when you fix the videos issue
What did you do this week? | ||
-------------------------- | ||
|
||
- This week, I started with Multiple actor support in skinning and managed to do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mutiple -> no need of upper case.
Done @skoudoro , PTAL |
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 50.41% 50.13% -0.28%
==========================================
Files 120 120
Lines 27160 27884 +724
Branches 3001 2961 -40
==========================================
+ Hits 13693 13981 +288
- Misses 13006 13436 +430
- Partials 461 467 +6
|
Thank you for the update. LGTM. merging |
blog is visible in
blog.html