Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding morphing support in gltf.py #700

Merged
merged 7 commits into from Oct 25, 2022

Conversation

xtanion
Copy link
Member

@xtanion xtanion commented Oct 4, 2022

NOTE: Skinning PR (#685) needs to be merged before merging this

Preview:
Using the MorphStressTest model and TheWave animation.

2022-10-05.00-12-14.mp4

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xtanion,

it is hard to see the difference. Can you rebase this PR?

Thank you!

@xtanion
Copy link
Member Author

xtanion commented Oct 13, 2022

Done @skoudoro PTAL

@m-agour
Copy link
Contributor

m-agour commented Oct 18, 2022

Hello @skoudoro @xtanion, when is this PR getting merged?

@skoudoro skoudoro merged commit 9a9699b into fury-gl:master Oct 25, 2022
@skoudoro
Copy link
Contributor

Tahnk you @xtanion, Look goods and works great

@skoudoro
Copy link
Contributor

you can start to rebase and update your PR @m-agour.

Thank you for waiting!

@m-agour
Copy link
Contributor

m-agour commented Oct 25, 2022

@skoudoro Thanks you. I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants