Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scientific domains #727

Merged
merged 45 commits into from Feb 6, 2023

Conversation

maharshi-gor
Copy link
Contributor

Feature

  • This PR introduces the new scientific domain design.
  • It will be available for all non-mobile platforms.

Fix

  • This PR also removes some of the commented codes
  • This PR fixes the favicon on all the pages. Instead of no icon on the tab, it will have the new fury logo next to the tab title

Changes

  • Only CSS and HTML files are changed in the process not causing any breaking changes.

Design

Screenshot 2023-01-25 at 10 35 31 PM

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Mk996, that is excellent!

Currently, the view more button is linked to nothing. Either we link all these buttons to some tutorials or we hide/comment these buttons until we create a real tutorial sections for each of the categories. We can not merge it with dead links.

What are the limitations to make it mobile friendly?

Otherwise, I love the design.

Thanks!

@maharshi-gor
Copy link
Contributor Author

Thank you @Mk996, that is excellent!

Currently, the view more button is linked to nothing. Either we link all these buttons to some tutorials or we hide/comment these buttons until we create a real tutorial sections for each of the categories. We can not merge it with dead links.

What are the limitations to make it mobile friendly?

Otherwise, I love the design.

Thanks!

Thanks @skoudoro for the feedback

There is no issue with mobile-friendliness, it is just work in progress and we want to do incremental updates
I am working on that

@skoudoro
Copy link
Contributor

ok, sounds good! So just waiting for view more buttons update/decision.

Thanks!

@skoudoro
Copy link
Contributor

Hi @Mk996,

What is the update concerning this PR?

@maharshi-gor
Copy link
Contributor Author

Hi @Mk996,

What is the update concerning this PR?

Updated redirections

@skoudoro
Copy link
Contributor

skoudoro commented Feb 6, 2023

All good, thank you for the link update. Merging

@skoudoro skoudoro merged commit 1b0f275 into fury-gl:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants