Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initialize management #744

Merged
merged 1 commit into from Feb 23, 2023
Merged

Conversation

skoudoro
Copy link
Contributor

this PR:

  • remove initialize from ShowManager init. : it creates a unwanted window (render is call inside initialize)
  • add initialize in add_timer_callback . iren need to be initialized before adding an observer

@skoudoro skoudoro added the type:Bug Fix Something isn't working label Feb 22, 2023
@Garyfallidis
Copy link
Contributor

A clarification here. The initializer is needed only with timer_callbacks but not in multithreaded cases.

@skoudoro
Copy link
Contributor Author

A clarification here. The initializer is needed only with timer_callbacks but not in multithreaded cases.

I confirm

@Garyfallidis
Copy link
Contributor

Merging. This closes #709 too.

@Garyfallidis Garyfallidis merged commit eb65780 into fury-gl:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants