Week 1 blogpost #797
Merged
Week 1 blogpost #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvcastillod
reviewed
Jun 8, 2023
| The problems I am having with these FBO implementations is first something related to how a FBO works, and second related to how VTK works. | ||
| In OpenGL, a custom user's FBO needs some things to be complete (usable): | ||
|
|
||
| 1. At least one buffer should be attatched. This buffer can be the color, depth or stencil buffer. |
| In OpenGL, a custom user's FBO needs some things to be complete (usable): | ||
|
|
||
| 1. At least one buffer should be attatched. This buffer can be the color, depth or stencil buffer. | ||
| 2. If no color buffer will be attatched then OpenGL needs to be warned no draw or read operations will be done to that buffer. Otherwise, there should be at least one color attachment. |
| In contrast, for some reason, the methods for 3D textures, `Allocate3D <https://vtk.org/doc/nightly/html/classvtkTextureObject.html#aaeefa46bd3a24bf62126512a276819d0>`_ works just fine. | ||
| I could use it as a workaround, but I do not wish to, as this just does not make sense. | ||
|
|
||
| My second problem relies VTK. As VTK is a library that encapsulates some OpenGL functions in more palatable forms, it comes with some costs. |
| My Current Problems | ||
| ------------------- | ||
|
|
||
| The problems I am having with these FBO implementations is first something related to how a FBO works, and second related to how VTK works. |
| My first problem relies on the third requirement. VTK's implementation of FBO requires a `vtkTextureObject <https://vtk.org/doc/nightly/html/classvtkTextureObject.html>`_ | ||
| as a texture attachment. I figured how to work with this class, however, I cannot allocate memory for it, as its methods for it, `Allocate2D <https://vtk.org/doc/nightly/html/classvtkTextureObject.html#abc91bbf9a3414bded7a132d366ca4951>`_, `Create2D <https://vtk.org/doc/nightly/html/classvtkTextureObject.html#a7e9dd67f377b7f91abd9df71e75a5f67>`_ and `Create2DFromRaw <https://vtk.org/doc/nightly/html/classvtkTextureObject.html#a0e56fe426cb0e6749cc6f2f8dbf53ed7>`_ | ||
| does not seem to work. Every time I try to use them, my program stops with no error message nor nothing. | ||
| For anyone interested in what is happening exacty, below is how I my tests are implemented: |
tvcastillod
reviewed
Jun 9, 2023
There was a problem hiding this comment.
@JoaoDell Overall it's good, I like that you gave a detailed explanation of your problem. I made some comments for you to review.
| -------------- | ||
|
|
||
| As mentioned in the last week's blogpost, the goal for that week was to investigate VTK's Framebuffer Object framework. | ||
| An update on that is that indeed, VTK has one more low-level working `FBO class <vtk.org/doc/nightly/html/classvtkOpenGLFramebufferObject.html>`_ that can be used inside FURY, however, |
There was a problem hiding this comment.
The link does not work for me. Try using this one instead https://vtk.org/doc/nightly/html/classvtkOpenGLFramebufferObject.html
There was a problem hiding this comment.
Yeah it doesn't work for me as well!
| 4. Each buffer should have the same number of samples. | ||
|
|
||
| My first problem relies on the third requirement. VTK's implementation of FBO requires a `vtkTextureObject <https://vtk.org/doc/nightly/html/classvtkTextureObject.html>`_ | ||
| as a texture attachment. I figured how to work with this class, however, I cannot allocate memory for it, as its methods for it, `Allocate2D <https://vtk.org/doc/nightly/html/classvtkTextureObject.html#abc91bbf9a3414bded7a132d366ca4951>`_, `Create2D <https://vtk.org/doc/nightly/html/classvtkTextureObject.html#a7e9dd67f377b7f91abd9df71e75a5f67>`_ and `Create2DFromRaw <https://vtk.org/doc/nightly/html/classvtkTextureObject.html#a0e56fe426cb0e6749cc6f2f8dbf53ed7>`_ |
ganimtron-10
reviewed
Jun 9, 2023
There was a problem hiding this comment.
Hey @JoaoDell ,
Nice Detailed Blog.
Just look into @tvcastillod's comment as she has covered all of them!
| -------------- | ||
|
|
||
| As mentioned in the last week's blogpost, the goal for that week was to investigate VTK's Framebuffer Object framework. | ||
| An update on that is that indeed, VTK has one more low-level working `FBO class <vtk.org/doc/nightly/html/classvtkOpenGLFramebufferObject.html>`_ that can be used inside FURY, however, |
There was a problem hiding this comment.
Yeah it doesn't work for me as well!
|
Thanks @ganimtron-10 and @tvcastillod for the reviews, I just adressed the issues you pointed out 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, here is my week 1 blogpost.
