New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added blogpost week 2 #802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tvcastillod nice blogpost and it built sucessfully here, just check my comments below and this will be ready to be merged 👍
What did I do this week? | ||
------------------------ | ||
|
||
I made some minor adjustments to the last PR I submit. Last time it was a draft since I was waiting for the weekly meeting to know how to proceed, but now is ready. I am waiting for the review so I can make the necessary corrections and adjustments to merge this first PR soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submit
-> I submitted
and now is ready
-> now it is ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tvcastillod ,
Short and Nice Blog.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all for the review. After fixing what is pointed by Joao, It will be ready to be merged
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
- Coverage 84.41% 84.32% -0.10%
==========================================
Files 43 43
Lines 10166 10173 +7
Branches 1381 1383 +2
==========================================
- Hits 8582 8578 -4
- Misses 1227 1239 +12
+ Partials 357 356 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the update, merging
Hello, here is the blog post for week 2.