Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blogpost week 2 #802

Merged
merged 3 commits into from Jun 19, 2023
Merged

Added blogpost week 2 #802

merged 3 commits into from Jun 19, 2023

Conversation

tvcastillod
Copy link
Contributor

Hello, here is the blog post for week 2.

week-2

Copy link
Contributor

@JoaoDell JoaoDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tvcastillod nice blogpost and it built sucessfully here, just check my comments below and this will be ready to be merged 👍

What did I do this week?
------------------------

I made some minor adjustments to the last PR I submit. Last time it was a draft since I was waiting for the weekly meeting to know how to proceed, but now is ready. I am waiting for the review so I can make the necessary corrections and adjustments to merge this first PR soon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submit -> I submitted and now is ready -> now it is ready

Copy link
Contributor

@ganimtron-10 ganimtron-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tvcastillod ,
Short and Nice Blog.
LGTM.

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all for the review. After fixing what is pointed by Joao, It will be ready to be merged

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #802 (902a2c4) into master (73e0a1a) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
- Coverage   84.41%   84.32%   -0.10%     
==========================================
  Files          43       43              
  Lines       10166    10173       +7     
  Branches     1381     1383       +2     
==========================================
- Hits         8582     8578       -4     
- Misses       1227     1239      +12     
+ Partials      357      356       -1     
Impacted Files Coverage Δ
fury/ui/containers.py 83.98% <100.00%> (+0.09%) ⬆️
fury/ui/elements.py 89.95% <100.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the update, merging

@skoudoro skoudoro merged commit 3842120 into fury-gl:master Jun 19, 2023
23 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants