This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
feat: Uglify-es support for quantum #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchanged
suggested changes
Oct 20, 2017
| @@ -24,6 +24,11 @@ export class QuantumPluginClass implements Plugin { | |||
| // remove uglify js | |||
| delete plugins[index]; | |||
| } | |||
| if (plugin.constructor.name === "UglifyESPluginClass") { | |||
| this.coreOpts.uglify = { es6:true, ...plugin.options }; | |||
There was a problem hiding this comment.
As far as I remember UglifyEs5 will complain about an unknown option. When passing the option, let's make sure es6 :true is not there (delete it)
It would great if you added documentation for that here:
https://github.com/fuse-box/fuse-box/blob/master/docs/quantum.md#installation
Good job!
There was a problem hiding this comment.
It got extracted later on via parameter destructuring here: { es6 = false, ...opts }
There was a problem hiding this comment.
Ok, can you add the docs please?
|
Well, I hope it's comprehensible. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked at gitter for the best way to design an API for it, but got no reply. So here is the simplest implementation possible, though it probably isn't very straightforward to use.
It picks up uglify's options from the
UglifyESPluginor could be triggered by quantum optionuglify: { es6: true }