Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetch implementation to solve forced lowercase header property names #533

Open
eksperts opened this issue Oct 5, 2017 · 4 comments

Comments

@eksperts
Copy link
Contributor

eksperts commented Oct 5, 2017

The fetch implementation we currently have seems to be somewhat outdated, leading to issues like this (forced lowercase header property names), while the standard has changed around that particular thing.

Prior to updating, needs extensive testing, since other changes might turn out to be backwards-incompatible.

Edit: this ticket is about fixing the fetch implementation around the header normalisation, so that property names are not forced to lowercase, according to the spec changes discussed in the linked ticket.

@fusebuild
Copy link
Collaborator

The forum thread Missing Header posted by papakay19@gmail.com was linked to this issue.

@kusma
Copy link
Contributor

kusma commented Oct 5, 2017

@eksperts: Would you mind filling in an exhaustive list of the things you know needs fixing? Otherwise this will quickly end up as one of those tickets that can never be closed...

@eksperts
Copy link
Contributor Author

eksperts commented Oct 5, 2017

@kusma this lowercase-headers thing is the only one I'm aware of. Changing this ticket to "fix this one thing" then.

If we had the time, someone from engineering or features could evaluate what other changes have been implemented since our fetch implementation snapshot. Such task needs prioritisation, and I leave that to you.

@eksperts eksperts changed the title Update fetch implementation Update fetch implementation to solve forced lowercase header property names Oct 5, 2017
@kusma
Copy link
Contributor

kusma commented Oct 5, 2017

@eksperts: Thanks.

@AndrewEQ AndrewEQ added this to Awesomeness Safe in Core Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
Awesomeness Safe
Development

No branches or pull requests

3 participants