Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared_ptr support is not present #51

Closed
ossdev07 opened this issue Jun 8, 2018 · 6 comments
Closed

shared_ptr support is not present #51

ossdev07 opened this issue Jun 8, 2018 · 6 comments

Comments

@ossdev07
Copy link
Contributor

ossdev07 commented Jun 8, 2018

shared_ptr support is missing in hawt jni so we made changes . verified it with librocksdbjni and raised the pull request

#50

@gnodet gnodet closed this as completed Apr 2, 2019
@gnodet gnodet reopened this Apr 2, 2019
@gnodet gnodet closed this as completed Apr 2, 2019
@gnodet
Copy link
Member

gnodet commented Apr 2, 2019

Can you add an example usage of shared_ptr to the hawtjni-example ? I fear it's somewhat broken.

@gnodet
Copy link
Member

gnodet commented Apr 2, 2019

I've reverted the merge of #50 until a working example is provided.

@gnodet
Copy link
Member

gnodet commented Apr 2, 2019

And btw, I'd like to release hawtjni this week, let me know if you plan to provide something soon.

@ossdev07
Copy link
Contributor Author

ossdev07 commented May 3, 2019

Reference to the newly generated PR #57 , provided the support of shared pointer with an example.
Test Report for the reference :
hawtjni_aarch64_testReport.txt

@ossdev07 ossdev07 closed this as completed May 3, 2019
@rhenwood-arm
Copy link

Hi @ossdev07 and @gnodet

As an Arm user, I have an interest in seeing this work landed.

@ossdev07 : I've looked briefly through the log file you posted. It is over 5K lines long. It apparently looks like a build task. Please can you highlight the example usage of 'shared_ptr' as it is no obvious to me.

@rhenwood-arm
Copy link

Ah, I see that this ticket has been closed, I will move my comments to #57 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants