Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is a great library, I like it so much, and I want to offer some advices #96

Open
kelinZhou opened this issue Nov 2, 2017 · 0 comments

Comments

@kelinZhou
Copy link

hello
this is a great library, I like it so much, and I want to offer some advices

  1. method that set reconnceting after disconnect sometimes doesn't work, no matter the disconnection happens the first time or later. For instance, when another session who has the same clientId as yours connect to the server, you will be logged out, in this case, if I set reconnection attempts no to 0, rapid reconnections emmits after every disconnection happens. I hope this could be fixed soon.

  2. When there is a persistent connection with server, connection.connect() crashes when invoked. This is not a good experience, wish this could be noticed by onFailure in callback instead of crush immediately.

  3. Method that could get current api is anticipated, for instance, isConnecting, isSuccessfullyConnected, and so forth. Beacause sometimes method connect doesn't instantly connect successfully after it is invoked(maybe some delay), this is the moment crush happens if connect is invoked again, so I wish similiar api could be provided

Thanks for your selfless contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant