Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input does not support UTF8 #1

Closed
fusetim opened this issue Jul 29, 2023 · 0 comments
Closed

Input does not support UTF8 #1

fusetim opened this issue Jul 29, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@fusetim
Copy link
Owner

fusetim commented Jul 29, 2023

Short description:
Using any UTF8 character that is not an ASCII char in an input will panic!

Why does it happen?
We use numerous method on String that can split or get a char that is not a UTF8 char boundary, therefore creating an invalid substring.

What should we do?
Use graphems and not chars.
Indeed even if we fix the original issue by checking or finding the closest UTF8 char boundary, it might introduce some weird behavior when using extended graphems (like emoji modifiers).

@fusetim fusetim added the bug Something isn't working label Jul 29, 2023
@fusetim fusetim added this to the v0.1.0 - First release milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant