Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when user click on blue userLocation #1122

Merged
merged 2 commits into from Mar 22, 2018

Conversation

telatao
Copy link
Contributor

@telatao telatao commented Mar 20, 2018

MKUserLocation blue userLocation MKAnnotation causes app to crash if inadvertently touched.
This modifications fixe this issue by testing the kind of clicked marker.

MKUserLocation blue userLocation MKAnnotation causes app to crash if inadvertently touched.
This modifications fixe this issue.
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2018

CLA assistant check
All committers have signed the CLA.

@mortoray
Copy link
Contributor

Can you provide a minimal UX example that I can test the defect and fix?

@telatao
Copy link
Contributor Author

telatao commented Mar 20, 2018

Yes sure, see the comments on the sample code:

<App>
	<StatusBarBackground Dock="Top"/>
	<JavaScript>
	var Observable = require("FuseJS/Observable");
	var GeoLocation = require("FuseJS/GeoLocation");

	 
	/***
     To get the Blue Location Marker (pull request #1122)
     How to reproduce:
     1/ click on the blue button displayed at your location
     => Crash

     With the fix : no crash.
	*/
	var timeoutMs = 5000;
    GeoLocation.getLocation(timeoutMs).then(function(location) {
    }).catch(function(fail) {
        console.log("getLocation fail " + fail);
    });


	module.exports ={
		
	}

	</JavaScript>
	<Panel>
		<NativeViewHost >
	            
	        
	            <MapView ux:Name="map" ShowCompass="true" ShowMyLocation="true" ShowMyLocationButton="true"   AllowScroll="true" >
	               
	            </MapView>            
	    </NativeViewHost>

</Panel>
</App>

Copy link
Contributor

@mortoray mortoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

@mortoray mortoray merged commit 06ebdd7 into fuse-open:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants