New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create tests to check all Raised errors #29

Open

5 tasks

shimwell opened this issue Aug 26, 2021 · 0 comments

Member

shimwell commented Aug 26, 2021

ValueErrors are raised when:

the material_tag is over 28
the material_tag is missing from the files_with_tags arg
file name does not end with .stp .step or .sat
filename is missing from the files_with_tags arg
when cubit can't be imported from the specified path

We could do with tests for all of these situations to see if the error really triggers the correct raised error.

Example on how to do this can be found here https://github.com/fusion-energy/paramak/blob/8b8b6e94b41899a2aefaa7fc616b2fb47179485a/tests/test_shape.py#L50-L56

We should probably also raise a warning when no graveyard is present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment