Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demos don't run in the CI workflows #86

Closed
RemDelaporteMathurin opened this issue Sep 14, 2021 · 3 comments
Closed

Demos don't run in the CI workflows #86

RemDelaporteMathurin opened this issue Sep 14, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@RemDelaporteMathurin
Copy link
Member

@shimwell it seems that the workflows including jupyter-cadquery don't work anymore.

Impacted: #85 #84

Apparently your last commit 695e391 on develop didn't pass the tests either.

I shall try and rebuild everything locally

@RemDelaporteMathurin RemDelaporteMathurin added the bug Something isn't working label Sep 14, 2021
@shimwell
Copy link
Member

shimwell commented Sep 14, 2021

Yep I made that tiny little commit just to see if the breakage was happening in the PRs or everywhere.

I can't see why this is behaving differently, I see the jupyter-cadquery setup tags specific versions of the dependencies so I think it is well protected from downstream changes.

Perhaps we need a minimal version of the bug without paramak code

@RemDelaporteMathurin
Copy link
Member Author

The problem is I can't reproduce the issue locally: i rebuilt the image, and run the exact same commands as in the yml files...

@shimwell
Copy link
Member

shimwell commented Sep 15, 2021

Rebuilding the dockerimage and uploading a new one to ghcr appears to have fixed this 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants