Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing migration for email and is_active changes #68

Closed
ivanvenosdel opened this issue Jan 27, 2016 · 4 comments
Closed

Missing migration for email and is_active changes #68

ivanvenosdel opened this issue Jan 27, 2016 · 4 comments

Comments

@ivanvenosdel
Copy link
Contributor

To reproduce with Django 1.9:

python manage.py makemigrations --dry-run

Migrations for 'authtools':
  0003_auto_20160128_0851.py:
    - Alter field email on user
    - Alter field is_active on user

These two changes don't seem to have migrations:

@jproffitt
Copy link
Contributor

I believe I fixed this in #67. But there has been no activity here since then, and no new release to pypi.

@ivanvenosdel
Copy link
Contributor Author

I saw that but wasn't sure as it said Django 1.8 and this doesn't come up unless the project is using 1.9. I can try this again with master if you don't get to it first.

@jproffitt
Copy link
Contributor

Should need the same fix for django 1.9. As far as I can tell, the help_text is the same for 1.8 and 1.9. But it was different for 1.7. So I believe django 1.7 will try to make a new migration. But that would have happened before my fix anyway.

A better solution might be to not hard code the help_text in the migration, but reference whatever django has for it. Not sure what the best thing to do would be. Because now, whenever django changes the help_text, authtools will need a new migration. And each new migration will make previous versions of django try to make a new migration.

@ivanvenosdel
Copy link
Contributor Author

@jproffitt I can confirm that your patch does fix the initial issue I reported. However now it is detecting new changes without a migration.

Migrations for 'authtools':
  0003_auto_20160128_0851.py:
    - Alter field email on user
    - Alter field is_active on user

Specifically the changes made in these two commits.

Updating my issue for this instead.

@ivanvenosdel ivanvenosdel changed the title Missing migration for Django 1.9 Missing migration for email and is_active changes Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants