Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with angular 14 #153

Open
Gillardo opened this issue Sep 5, 2022 · 27 comments
Open

Does not work with angular 14 #153

Gillardo opened this issue Sep 5, 2022 · 27 comments

Comments

@Gillardo
Copy link

Gillardo commented Sep 5, 2022

Follow the steps on the readme file but use angular 14 and you get this error when trying to run ng serve

image

@Gillardo
Copy link
Author

Gillardo commented Sep 5, 2022

Here is a sample project, just run npm install and then ng serve and you should replicate the problem

fusion-charts.zip

@spac-valentin
Copy link

Is there a plan to start supporting angular 14 soon?

@hebus
Copy link

hebus commented Sep 19, 2022

As a workaround, you can put the "angular-fusioncharts"'s source code inside you Angular 14 project... And all should works fine

@epiphanizer
Copy link

@hebus Your workaround got it compiling, but actual loading of charts fails with ERROR TypeError: Cannot read properties of null (reading 'firstCreatePass')
at providersResolver (core.mjs:21149:13)

Any thoughts? Should I just use 13?

@hebus
Copy link

hebus commented Sep 23, 2022

Hello @epiphanizer ,
Here a stackblitz link: https://stackblitz.com/edit/angular-ivy-32bzyf

Don't worry, if does not work online, just download the source code and test it in local. This is how we have fixed Angular 14 compilation issues

@ajeet2017
Copy link

@hebus in angular 14 got compile successfully. but while load page throw error. ypeError: Cannot read properties of null (reading 'firstCreatePass'). Is it version issue? how can I resolve.

@jerone
Copy link

jerone commented Oct 12, 2022

@fusioncharts
We are paying customers and our applications are being held back by this one package lacking support for newer versions of Angular.

This discussion also started with Angular 12, then with version 13 and now with 14.

For the previous versions, the upgrade was possible by forcing the upgrade.
Now with version 14 of Angular, this is not possible anymore, and blocking exceptions are thrown.

Angular 14 is out for 4+ months now.
Please hold an higher release schedule for supporting new versions of Angular.

@jerone
Copy link

jerone commented Oct 24, 2022

@fusioncharts I've created #154 to upgrade to Angular 14.

@jprinsloo
Copy link

@fusioncharts please merge #154 and make a new package for us to use.

@jerone
Copy link

jerone commented Nov 19, 2022

And now we are multiple version behind again, with Angular 15 just released.

I don't know why I pay for this product !!!

@abishek
Copy link

abishek commented Nov 22, 2022

When I spoke to their support, they didn't even have an ETA, and their claim was - this is an open-source project, so we cannot expect them to deliver or support. unfortunately, they don't seem to know why or how open-source works: they are not even open to merging community patches. Unfortunately, moving away is not a simple decision either :-(

@jerone would it be possible to publish your patched version as an unofficial package?

@jerone
Copy link

jerone commented Nov 23, 2022

The argument about being an open-source project is confusing. They maintain this repo, plus they mention support for Angular multiple times on their website. 1. 2.

I'll contact them too, asking to prioritize this blocking issue.

[..] they are not even open to merging community patches.

Exactly, the work is already done #154 (if they confirm everything is working correctly).

@jerone would it be possible to publish your patched version as an unofficial package?

I have to think about this and discuss this internally, as I forked this repo from my companies org. I try to stay away from publishing clones, because I cannot and will not give support if we unofficially publish it.

@Franccescalee
Copy link

Franccescalee commented Nov 23, 2022

Same issue trying to upgrade my app to Angular 14. We only purchased our license due to the fact that they said it "had support for Angular".

@jerone

This comment was marked as off-topic.

@jerone
Copy link

jerone commented Dec 20, 2022

Some activity happening:

@unspike
Copy link

unspike commented Jan 16, 2023

@fusioncharts We are paying customers and our applications are being held back by this one package lacking support for newer versions of Angular.

This discussion also started with Angular 12, then with version 13 and now with 14.

For the previous versions, the upgrade was possible by forcing the upgrade. Now with version 14 of Angular, this is not possible anymore, and blocking exceptions are thrown.

Angular 14 is out for 4+ months now. Please hold an higher release schedule for supporting new versions of Angular.

@jerone how did u solved issue on angular 12? I have Cannot read properties of null (reading 'firstCreatePass') issue (on prod only, and only on hosted machine, locally 'prod' build also works, and can't find the solution

@jerone

This comment was marked as off-topic.

@unspike
Copy link

unspike commented Jan 16, 2023

@jerone yeah, but u said

For the previous versions, the upgrade was possible by forcing the upgrade.

can you please clarify what do u mean by that.

@jerone

This comment was marked as off-topic.

@AdiSilagy
Copy link

We are also paying customers and we are forced to upgrade to Angular 14.
Did anyone managed to work around this issue?

@ghost
Copy link

ghost commented Feb 7, 2023

What a lamentable business. They need to remediate this things to avoid paying for a license for something that you cannot upgrade.

@Franccescalee
Copy link

Franccescalee commented Feb 9, 2023

We are also paying customers and we are forced to upgrade to Angular 14. Did anyone managed to work around this issue?

@AdiSilagy We had to clone the repository and upgrade it ourselves. Then published to a private NPM package.

@yuricamara
Copy link

yuricamara commented Mar 15, 2023

@Franccescalee , how did you upgrade it? Please, let us know.

@Franccescalee
Copy link

@yuricamara I think I just changed the angular packages in the package.json to go to 14.x before I did an npm install. I compared what was in there to what I have in my app as well. Then built/packed/published. I don't remember needing to make any changes to the code.

@AyanBhadury
Copy link

AyanBhadury commented Mar 30, 2023

Hello,

The latest version of angular-fusioncharts has just been released that is angular-fusioncharts 4.0.3 . This version supports angular version till the latest one (15). If you want you can upgrade the angular version and test your application.

Here is the npm link :
https://www.npmjs.com/package/angular-fusioncharts/v/4.0.3

Demo - https://github.com/AyanBhadury/angular-fusioncharts-sample

@jerone
Copy link

jerone commented Apr 3, 2023

Super great news. I'll give it a try soon. 🎉

Can you please create an CHANGELOG to keep track of the changes. Preferably via the "Releases" tab. Many corporation need to track the changes.

Are there for example no breaking changes?
Upgrade guide?

But more important, Angular 16 is less then 1 month away ("week of 2023-05-01").

https://angular.io/guide/releases#release-schedule
Please add support for Angular 16 ASAP !!!

@AyanBhadury
Copy link

Sorry I don't have the permission, may be create a ticket to support@fusioncharts.com and request them to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.