Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of uninitialized value $ip in string eq at Hardware.pm #633

Closed
mathieumd opened this issue Feb 7, 2019 · 3 comments
Closed

Use of uninitialized value $ip in string eq at Hardware.pm #633

mathieumd opened this issue Feb 7, 2019 · 3 comments

Comments

@mathieumd
Copy link

Looks like I have the same problem as #441.

But I installed the latest available Debian package (fusioninventory-agent-task-network_2.4-2_all.deb as listed here), and the two fixes from #526 doesn't seems to be present in this package, as my /usr/share/fusioninventory/lib/FusionInventory/Agent/Tools/Hardware.pm still has the old lines not fixed:

-         next if $ip eq '0.0.0.0';
+         next if (!defined($ip) || $ip eq '0.0.0.0');

Is there another source of official packages more frequently updated?

@g-bougard
Copy link
Contributor

Hi @mathieumd

sorry, I missed to fix the linux deb installation page you're pointing. Actually packages are built by Debian and are available in Sid. 2.4-2 is then obsolete and you should use 2.4.2-2. I know the numbering is actually a little confusing...

I just updated the linux deb installation page with the link you should use.

You can notice a package has been added for the Collect task. This package is of course not mandatory and you should only install it if you need to collect file status from a Collect task in plugin.

As 2.4.2-2 version includes the fix you're looking for, I'm closing the issue.

Thank you for the doc update reminder O:)

@mathieumd
Copy link
Author

2.4-2 is then obsolete and you should use 2.4.2-2

I guess you meant 2.4.2-1, which is available in Buster, and contains the fix, right?

Regarding the documentation, I may be blind, but I still see version 2.4-2 (Method 1) and 2.3.10.1-1 (Method 2) on the page Installation on Debian and Ubuntu. It's confusing, since it looks like you recommend to download all packages from Debian repository and not your own (because it stops at version 2.4-2 versus 2.4.2-1 for Debian's?).

@g-bougard
Copy link
Contributor

Humpf, yes, you're right about the version.

Sorry I fixed the page in the wrong branch. This is fixed and the page is now up-to-date.

Thank you for the feedback ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants