Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Delete this repo #16

Closed
mlmorg opened this issue Jan 9, 2018 · 3 comments
Closed

Delete this repo #16

mlmorg opened this issue Jan 9, 2018 · 3 comments

Comments

@mlmorg
Copy link

mlmorg commented Jan 9, 2018

I don't see the point of having this repo differ from https://github.com/uber-web/uber-eslint/tree/next/packages/eslint-config-uber-universal-stage-3. Should we just delete this one and make the uber-eslint config match what we use here?

@KevinGrandon
Copy link
Contributor

Also the import rule, but those could live in the uber-web version.

It just depends if we want to have custom linter rules for fusion apps or not, I could see those being useful and something that we might want to have here.

@rtsao
Copy link
Member

rtsao commented Jan 9, 2018

I think eventually this repo will probably have more specialized rules and configuration tailored for fusion apps. If anything, I feel like we should delete the other package.

@mlmorg
Copy link
Author

mlmorg commented Jan 9, 2018

It seems like this repo as it stands today could be useful for a lot of things outside of just fusion apps. If we expect this to change then I think we could keep this repo, but it seems like it would make more sense to fold all the changes currently in this repo into eslint-config-uber-universal-stage-3 and then have this repo simply extend from that with no additional functionality (until the point that we need to be different between fusion apps and, say, fusion plugins or react components or something...).

@mlmorg mlmorg closed this as completed Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants