Unable to resolve "core-js/modules/es7.promise.finally"

[chrisirhc]

Type of issue

Bug

Description

After upgrading to fusion-cli 1.13.1, I saw this unable to resolve error originating from fusion-cli/entries/.
I found that this is likely due to babel-env has a reference to es7.promise.finally.

https://github.com/babel/babel/blob/c586d4e8cac816941bf2ba559472fd9cc3150921/packages/babel-preset-env/src/built-in-definitions.js#L49

However, core-js 2.4 and 2.5 do not have the es7.promise.finally module. It was only introduced in 2.6 (zloirock/core-js@ed59a9c).

I inspected yarn.lock and package.json of respective modules (fusion-cli) and @babel/polyfill specifies core-js@^2.5.7 which doesn't force an upgrade of core-js:

https://github.com/babel/babel/blob/c586d4e8cac816941bf2ba559472fd9cc3150921/packages/babel-polyfill/package.json#L14

Current behavior

Upgrade to 1.13.1 with has unable to resolve error.

Expected behavior

Upgrade to 1.13.1 with no issues.

Steps to reproduce

1. Make sure that core-js is not in the package.json
2. Upgrade to fusion-cli 1.13.1.

Your environment

• fusion-cli version: 1.13.1

[chrisirhc]

core-js@^2.5.7 is actually correct as indicated in babel/babel#9241 (comment) . Looks like this is a yarn/dedupe issue. Closing this out.