Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context to render function #243

Merged
merged 2 commits into from Apr 10, 2019
Merged

Pass context to render function #243

merged 2 commits into from Apr 10, 2019

Conversation

ganemone
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #243   +/-   ##
======================================
  Coverage    74.8%   74.8%           
======================================
  Files          13      13           
  Lines         262     262           
  Branches       55      55           
======================================
  Hits          196     196           
  Misses         49      49           
  Partials       17      17
Impacted Files Coverage Δ
src/index.js 71.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5ba37...f187d53. Read the comment docs.

Copy link
Member

@chrisdothtml chrisdothtml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Just curious about the reasoning for adding it now (or why it wasn't passed in until now)

@ganemone
Copy link
Contributor Author

Looks fine to me. Just curious about the reasoning for adding it now (or why it wasn't passed in until now)

Just something that was overlooked.

@ganemone
Copy link
Contributor Author

!merge

@old-fusion-bot old-fusion-bot bot merged commit 41c0222 into fusionjs:master Apr 10, 2019
@old-fusion-bot
Copy link

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants