disable manageStatus #34
Conversation
jmontleon
force-pushed
the
disable-status
branch
from
e4ae956
to
95cfb8c
Compare
|
controller and ui will probably need api versions adjusted. Old settings seem forward compatible, so shouldn't be a problem to update them. This should get velero/restic working at least, back to 3.7. |
|
Special thanks to @fabianvf for saving our bacon. |
|
Will test this on a 4.x cluster, then add approval if it works ⚡ |
jmontleon
force-pushed
the
disable-status
branch
from
95cfb8c
to
54e3d73
Compare
|
Works on 4.1 |
|
The scc clusterrole isn't working on 3.7. Let me see what I can find. |
jmontleon
force-pushed
the
disable-status
branch
3 times, most recently
from
3348b40
to
0307b43
Compare
jmontleon
force-pushed
the
disable-status
branch
from
0307b43
to
210162a
Compare
| @@ -186,18 +186,47 @@ roleRef: | |||
| name: cluster-admin | |||
| apiGroup: rbac.authorization.k8s.io | |||
| --- | |||
| kind: ClusterRoleBinding | |||
There was a problem hiding this comment.
Not the preferred way anymore, but the new way doesn't seem to work with 3.7. This is fine... it's just creating a new scc instead of a clusterrole for the existing one.
There was a problem hiding this comment.
For 4.x we can keep the clusterrole(binding) via OLM.
There was a problem hiding this comment.
Worked for me on 4.1. I'm not able to remove mig components anymore by modifying the MigrationController resource, but I think being able to deploy to 3.7-3.10 is much more important than the loss of that functionality, we can always figure out why that's not working if it's important down the road.
| @@ -33,7 +33,7 @@ spec: | |||
| served: true | |||
| storage: true | |||
| --- | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| apiVersion: rbac.authorization.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
How does the apiVersion change to beta1 contribute to the solution? Just curious?
There was a problem hiding this comment.
RBAC went to v1 in 1.8, so for 3.7 clusters they would only have the 'v1beta1' endpoint.
Assuming that the v1beta1 endpoint is still present on newer versions so by using that endpoint could be way to have same code work with rbac on 3.7+
| @@ -3,3 +3,4 @@ | |||
| group: migration.openshift.io | |||
| kind: MigrationController | |||
| role: /opt/ansible/roles/migrationcontroller | |||
| manageStatus: False | |||
No description provided.