Build plugin external image #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
approved these changes
Sep 20, 2019
sseago
force-pushed
the
build-plugin-external-image
branch
from
b576e5f
to
15beaa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in fixes for the following issues with build/buildconfig:
This commit fixes several problems with the build plugin:
Don't abandon other (pull/push secret) items if image is external
Take into account image refs in several locations, not just SourceStrategy
Filter image ref consideration on DockerImage kind
Only modify push/pull secret if the corresponding secret is the default
builder-dockercfg- secret (and is present). For empty secrets,
leave empty, and for custom secrets, leave as-is since those are migrated.
Take into account push/pull secrets in all relevant locations, not just
SourceStrategy and Output.
Apply all of the above to BuildConfig as well