Fix NewlineLogOutputDecoder

[fanatid]

Currently NewlineLogOutputDecoder works incorrect, decode always produce message even if no \n at end of line. decode also remove newline, so it's not possible distinguish is it was part of message of full message. shiplift implements this correctly, see https://github.com/softprops/shiplift/blob/a4cd2185976ad56b880d5a10374c4dee6d116e6a/src/tty.rs#L79-L147

• What should be fixed for this change in crate?
• Since this breaking change, 0.7.0 will be required, is this ok for you?
• What about return Bytes instead String?

[fussybeaver]

Nice.. I was thinking of replacing it with the tokio util LinesCodec ( https://docs.rs/tokio-util/0.3.1/tokio_util/codec/struct.LinesCodec.html ), but this implementation is also good!

Can you adjust the integration tests to add the newline?

[fanatid]

Yeah, I was thought about LinesCodec too, but decide go with own impl because no need looking up \n symbol, we know size of message from header.

What you think about switch to Bytes instead String?

[fussybeaver]

Yes, it should be fine to switch to Bytes, it's only used in one endpoint as far as I can see.

[fanatid]

I changed String to Bytes and fixed integration tests.

[fussybeaver]

Thanks.. I will make a 0.7 release

[fanatid]

Great! Thank you!