Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target temperature value in python-ariston-api #279

Closed
robertomontinaro80 opened this issue Jan 19, 2024 · 0 comments
Closed

Add target temperature value in python-ariston-api #279

robertomontinaro80 opened this issue Jan 19, 2024 · 0 comments
Assignees

Comments

@robertomontinaro80
Copy link
Contributor

Hi @fustom I think it would be useful to add in python-inariston-api the following function in galevo_device.py:

def get_target_temp_value(self, zone: int) -> int: """Get zone comfort temp value""" return self._get_item_by_id( ThermostatProperties.ZONE_DESIRED_TEMP, PropertyType.VALUE, zone )

So it could be used in ariston-remotethermo-home-assistant-v3 project in the climate.py to fix the wrong value displayed for target temp.
Below the proposed fix:
FROM:
@property def target_temperature(self) -> float: """Return the target temperature for the device.""" return self.device.get_comfort_temp_value(self.zone)
TO
@property def target_temperature(self) -> float: """Return the target temperature for the device.""" return self.device.get_target_temp_value(self.zone)

Hope this could be useful. Thanks.

@fustom fustom self-assigned this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants