Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): send report to each slack channel #1530

Merged
merged 2 commits into from Sep 29, 2022

Conversation

tomofumi0003
Copy link
Contributor

@tomofumi0003 tomofumi0003 commented Sep 9, 2022

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

fix vuls report not send to each server name's channel.
(when slack's channel is "${servername}" in configuration file)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • set to slack's channel is "${servername}"
  • vuls report -to-slack

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

reporter/slack.go Outdated Show resolved Hide resolved
@MaineK00n MaineK00n changed the title fix send report to each slack channel fix(report): send report to each slack channel Sep 12, 2022
reporter/slack.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@MaineK00n MaineK00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kotakanbe kotakanbe merged commit 6963442 into future-architect:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants