Support email one-line format #674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotakanbe
reviewed
Jun 24, 2018
| if conf.formatOneLineSummary{ | ||
| message += formatOneLineSummary(r) + "\r\n\r\n" | ||
| } | ||
| else{ |
There was a problem hiding this comment.
[go vet]
expected statement, found 'else'
kotakanbe
reviewed
Jun 24, 2018
| if conf.formatOneLineSummary{ | ||
| message += formatOneLineSummary(r) + "\r\n\r\n" | ||
| } | ||
| else{ |
There was a problem hiding this comment.
[Golint]
expected statement, found 'else'
|
@nikoren Please fix the warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #633
How did you implement it:
Added logic to consider additional flag
How can we verify it:
run with
vuls report -to-email -format-one-line-text -format-one-emailand get short emailTodos:
You don't have to satisfy all of the following.
make fmtmake testIs this ready for review?: NO
Is it a breaking change?: NO