feat(report): CERT notification to slack #767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotakanbe
reviewed
Jan 24, 2019
|
@kazuminn Please paste the test result. |
|
@kotakanbe I tested it with the following pattern in the test.
|
kazuminn
changed the title
kazuminn
changed the title
kotakanbe
reviewed
Feb 9, 2019
report/slack.go
Outdated
| if len(jpalert) != 0 && len(usalert) == 0 { | ||
| certAlert = fmt.Sprintf("<%s|JPCERT>", jpalert) | ||
| } else if len(usalert) != 0 && len(jpalert) == 0 { | ||
| certAlert = fmt.Sprintf("<%s|USCERT", usalert) |
There was a problem hiding this comment.
kotakanbe
requested changes
Feb 9, 2019
| return fmt.Sprintf("*%4.1f (%s)* %s %s\n%s\n```\n%s\n```%s\n%s\n", | ||
| certAlert := "" | ||
| var jpalert string | ||
| for _, ja := range vinfo.AlertDict.Ja { |
There was a problem hiding this comment.
Sometimes, one CVE has multiple alerts.
Your code overwrites the alert, so your code can not show multiple alerts.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742
What did you implement:
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
You don't have to satisfy all of the following.
make fmtmake test***Is this ready for review?:***YES
Reference