Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In non-English books, and the title in the toc garbled #42

Closed
chappyhome opened this issue Sep 6, 2013 · 5 comments
Closed

In non-English books, and the title in the toc garbled #42

chappyhome opened this issue Sep 6, 2013 · 5 comments
Labels

Comments

@chappyhome
Copy link

Screenshot below:
image

@chappyhome
Copy link
Author

I tested again after only online unpack epub a situation, as already unzipped does not happen.

@fchasen
Copy link
Contributor

fchasen commented Sep 9, 2013

Yikes - what language is this occurring with?

@DokaMax
Copy link

DokaMax commented Oct 11, 2013

Also have this problem on russian books.
So far found reason here:

Used encoding in:

unarchiver.js

EPUBJS.Unarchiver.prototype.getText = function(url){

entry.getText(function(text){
deferred.resolve(text);
}, null, null, 'ISO-8859-1'

after change to UTF-8 - works fine for me.

BTW - this connected to page title also.

@X-Ryl669
Copy link

X-Ryl669 commented Jan 7, 2014

I second that. The page is claiming UTF-8 encoding, yet it's giving ISO-8859-1 text. The fix is easy

@fchasen
Copy link
Contributor

fchasen commented Jan 9, 2014

Great - I've added parsing the encoding from the opf file and defaulted to utf-8 in v0.1.8

If you happen to have a book that wasn't working before and is public domain, please submit a pull request to https://github.com/futurepress/books so I test with it.

Thanks

@fchasen fchasen closed this as completed Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants