Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tcMenu 4.1 or later broken #37

Open
futurexdesign opened this issue Nov 14, 2023 · 1 comment
Open

Upgrade to tcMenu 4.1 or later broken #37

futurexdesign opened this issue Nov 14, 2023 · 1 comment
Assignees

Comments

@futurexdesign
Copy link
Owner

Cannot upgrade to tcMenu greater than 4.0, as menuManager->activateMenuItem has been removed from the library.

Will need to explore a workaround for this, as we use this method for locking the current menu item when a cycle is running, and to keep the cursor from escaping the menu bar.

This also causes issues with builds in current main, as the dependency auto upgrades to 4.1 (not locked to 4.0 in the platformio.ini file currently.. will fix..)

@bonzer35 If you are up for an exploratory battle, take a swing at it :D

@futurexdesign
Copy link
Owner Author

Temp work around to get main to build..

platformio.ini line 18, change davetcc/tcMenu@^4.0.0 to davetcc/tcMenu@4.0.0, this locks the dependency to 4.0.0, which will build. Without this, platformio will pull 4.1.1, which has the breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants