Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

API v3 #72

Closed
Fuyukai opened this issue Sep 5, 2016 · 10 comments
Closed

API v3 #72

Fuyukai opened this issue Sep 5, 2016 · 10 comments
Assignees
Milestone

Comments

@Fuyukai
Copy link
Owner

Fuyukai commented Sep 5, 2016

So I'm gonna be making a v3 to fix some issues v2 has (notably the region issues and the comp/qp split).

(No, I'm not retiring v2 (yet)).

I'm looking on opinions on what to split and what to unify:

  • Comp and quickplay together (i.e {"competitive": ..., "quickplay": ...})
  • Heroes and other stats together

Basically, if it should be a giant JSON blob (easier) or multiple routes (pls senpai nginx can only take so much on an Atom).

@Fuyukai Fuyukai added this to the v3 milestone Sep 5, 2016
@Fuyukai Fuyukai self-assigned this Sep 5, 2016
@Fuyukai
Copy link
Owner Author

Fuyukai commented Sep 5, 2016

Oh yeah, this also means all 3 regions and 3 platforms will be available in one request, as well as taking shorter time due to fetching all regions in parallel.

@andrewzah
Copy link
Collaborator

andrewzah commented Sep 5, 2016

So v3 will keep the new competitive: true field? Makes sense to cut down on the routes.

@Js41637
Copy link
Contributor

Js41637 commented Sep 6, 2016

I'd assume it will return both quickplay and competitive stats in the one request (if available) and return all hero stats on a /heroes route.

Regions (and platforms) make things a lot harder. That's up to 5 requests for a single user to try and find their location not to mention some users are on multiple regions.

@ifonefox
Copy link

ifonefox commented Sep 6, 2016

nginx can only take so much on an Atom

You're self-hosting this on a computer with an Atom Processor?

@Fuyukai
Copy link
Owner Author

Fuyukai commented Sep 6, 2016

eyes@veriny /v/w/owapi.net$ cat /proc/cpuinfo | grep "model name"
model name  : Intel(R) Atom(TM) CPU  C2750  @ 2.40GHz
model name  : Intel(R) Atom(TM) CPU  C2750  @ 2.40GHz
model name  : Intel(R) Atom(TM) CPU  C2750  @ 2.40GHz
model name  : Intel(R) Atom(TM) CPU  C2750  @ 2.40GHz

@Fuyukai Fuyukai mentioned this issue Sep 8, 2016
@RomainPln
Copy link

I agree all heroes stats together would help avoid 429 warnings.

@andrewzah
Copy link
Collaborator

When is v3 going to be merged in?

@Fuyukai
Copy link
Owner Author

Fuyukai commented Sep 14, 2016

soontm

@andrewzah
Copy link
Collaborator

I'm not sure how I can contribute to v3, but if there's something I can do just let me know.

@Fuyukai
Copy link
Owner Author

Fuyukai commented Sep 15, 2016

Well, I'm going to fix platforms and merge it to master tonight, then deploy it, so I need testers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants